Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Connection Feature added, edit existing connection in connection tree. #10214

Merged
merged 93 commits into from
May 5, 2020
Merged

Edit Connection Feature added, edit existing connection in connection tree. #10214

merged 93 commits into from
May 5, 2020

Conversation

smartguest
Copy link
Contributor

Edit Connection now works thanks to a new matcher feature made by @aaomidi when a connection is edited, even with the URI being changed, the profile on the connection tree will remain the same instead of being duplicated. Past connections (for URI changes in a profile) are still kept on recent connections, but could be useful for reverting the connection profile just in case.

This PR fixes #5158

@smartguest
Added Edit Connection Command
17845c4
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
6ad19b5 
…into alex/newconnection
@smartguest
Wip changes for new connection dialog
e9b8be6
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
64504e4 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
82972f8 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
a11e43f 
…into alex/newconnection
@smartguest
Testing
e6021d0
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
e01d5d0 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
5d94452 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
41ff446 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
cf50024 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
dfe9ed8 
…into alex/newconnection
@smartguest
WIP commit
575a8df
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
9eca366 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
37f3c6d 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
3c7630a 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
ad7afc3 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
1abe551 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
610662e 
…into alex/newconnection
@smartguest
added ID check to ensure connection
76d0855
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
b9a467b 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
b95b430 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
849afa9 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
9460c86 
…into alex/newconnection
@smartguest
wip commit
fe410e9
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
7453797 
…into alex/newconnection
@smartguest
model id check implemented
ca3f0c0
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
7bcaa9a 
…into alex/newconnection
@smartguest
addfooterbutton now accepts events
374ff6b
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
ebb2826 
…into alex/newconnection
smartguest added 10 commits April 24, 2020 16:04
@smartguest
saveprofile fixed
e1ef6be
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
c5d553a 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
c14ccc9 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
9706945 
…into alex/newconnection
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
662fef4 
…into alex/newconnection
@smartguest
wrote working test
faf5d9f
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
b60b65f 
…into alex/newconnection
@smartguest
added additional test
3a8981b
@smartguest
Merge branch 'master' of https://github.com/microsoft/azuredatastudio …
96c0b98 
…into alex/newconnection
@smartguest
changed message
09603ed
@github-actions
Copy link

Coverage Status

Coverage increased (+0.05%) to 32.702% when pulling 09603ed on alex/newconnection into 3531156 on master.

aaomidi
aaomidi suggested changes Apr 29, 2020
View reviewed changes
@smartguest smartguest requested a review from aaomidi May 1, 2020 20:29
aaomidi
aaomidi approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@aaomidi aaomidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but since the PR is introducing a new profile matcher technique let's make sure to get another sign off.

@smartguest smartguest merged commit 921e546 into master May 5, 2020
smartguest added a commit that referenced this pull request May 5, 2020
@smartguest
Revert "Edit Connection Feature added, edit existing connection in co…
a3c3378 
…nnection tree. (#10214)"

This reverts commit 921e546.
This was referenced May 5, 2020
Closed
Closed
@aaomidi aaomidi deleted the alex/newconnection branch July 31, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaomidi aaomidi aaomidi approved these changes

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@kburtram kburtram Awaiting requested review from kburtram

@anthonydresser anthonydresser Awaiting requested review from anthonydresser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit properties of a server without recreating the connection
3 participants
@smartguest @aaomidi @Charles-Gagnon