Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render before adding to the splitView #10261

Merged
merged 1 commit into from
May 5, 2020
Merged

Render before adding to the splitView #10261

merged 1 commit into from
May 5, 2020

Conversation

aaomidi
Copy link
Contributor

@aaomidi aaomidi commented May 4, 2020

This PR fixes #10213

It looks like the adding to splitView depends on this.body of the AccountPanel to not be undefined. This field gets populated in the render() method:

this.body = append(this.element, $('.pane-body'));

So calling render before adding to the splitView should fix the problem.

@aaomidi aaomidi requested review from anthonydresser and Charles-Gagnon and removed request for anthonydresser May 4, 2020 19:06
@coveralls
Copy link

Coverage Status

Coverage remained the same at 32.731% when pulling bd0f300 on amir/fix/azurePane into 3e5b7fd on master.

@aaomidi
Copy link
Contributor Author

aaomidi commented May 4, 2020

I'm not super familiar with the splitView code, is this the correct solution or is this fixing a symptom caused by somewhere else?

@aaomidi aaomidi requested a review from abist May 4, 2020 20:44
@ranasaria
Copy link
Contributor

I have verified that the fix resolves the issue.

@ranasaria
Copy link
Contributor

I'm not super familiar with the splitView code, is this the correct solution or is this fixing a symptom caused by somewhere else?

The change is simple enough that if there is a better fix we can do it later.

@ranasaria
Copy link
Contributor

The fix looks good to me. As long as we understand why this was not needed before we should be good.

@aaomidi aaomidi merged commit 5105694 into master May 5, 2020
@aaomidi aaomidi deleted the amir/fix/azurePane branch May 5, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PaneView broken on latest ADS Master
4 participants