Fix/prev next links issue #10523
Merged
Fix/prev next links issue #10523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corivera
reviewed
May 20, 2020
Charles-Gagnon
approved these changes
Jun 4, 2020
src/sql/workbench/services/notebook/browser/notebookServiceImpl.ts
Outdated
Show resolved
Hide resolved
| @@ -186,7 +186,7 @@ | |||
| } | |||
| }, | |||
| { | |||
| "command": "notebook.command.searchUntitledBook", | |||
| "command": "notebook.command.searchProvidedBook", | |||
There was a problem hiding this comment.
are there any places where we're referencing notebook.command.searchUntitledBook?
There was a problem hiding this comment.
we use it for search on the items in Provided Books viewlet.
There was a problem hiding this comment.
ok. just wanted to make sure that anything that referenced the old command name has been updated.
chlafreniere
approved these changes
Jun 12, 2020
| @@ -120,9 +118,9 @@ export async function activate(extensionContext: vscode.ExtensionContext): Promi | |||
| } | |||
|
|
|||
| let workspaceFolders = vscode.workspace.workspaceFolders?.slice() ?? []; | |||
| const bookTreeViewProvider = new BookTreeViewProvider(appContext.apiWrapper, workspaceFolders, extensionContext, false, BOOKS_VIEWID); | |||
| const bookTreeViewProvider = new BookTreeViewProvider(appContext.apiWrapper, workspaceFolders, extensionContext, false, BOOKS_VIEWID, NavigationProviders.NotebooksNavigator); | |||
There was a problem hiding this comment.
this is totally random but this reminds me of a baseball team near where i grew up:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #10501
Previous and next navigation buttons are rendered correctly only on one viewlet at any point of time, depending on which one has the last book opened. That's because every time we open a book, we're registering a new navigationProvider with the same providerid which is basically overriding the existing ones.
In this PR I added a different provider for each viewlet and while retrieving the correct provider used the existing context key to get the appropriate one.
Am not sure if there are better ways to do this, so would like your feedback for improving this.