Final ADS-side hookup for sqlcmd vars #10815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const varName = sqlCmdVar.getAttribute(constants.Include); | ||
|
|
||
| const varValue = sqlCmdVar.getElementsByTagName(constants.DefaultValue)[0].childNodes[0].nodeValue; | ||
| this.sqlCmdVariables[varName] = varValue; |
There was a problem hiding this comment.
tell me if I understand correctly - we are only taking the values from proj file as is?
(we should give a way to edit at deployment time... through profile or in the dialog itself like SSDT)
There was a problem hiding this comment.
Yup, it's just passthrough from the sqlproj file here to make sure it has proper interop with projects coming from SSDT. I figured variable editing would happen when we get something like a project properties dialog going since that's the existing experience for defining and setting them.
Made #10841 to track
kisantia
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #10703 by adding support for reading sqlcmdvars from the project file, and adds a test for confirming they're part of the final deployment/script generation task profiles.