Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format sqlproj file XML on serialization #10818

Merged
merged 5 commits into from
Jun 11, 2020
Merged

Format sqlproj file XML on serialization #10818

merged 5 commits into from
Jun 11, 2020

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Jun 9, 2020

Fixes #10772

@@ -2225,6 +2227,51 @@ EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
=========================================
END OF winreg NOTICES AND INFORMATION

%% xmldom NOTICES AND INFORMATION BEGIN HERE
=========================================
Copy link
Contributor

@udeeshagautam udeeshagautam Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you already have great, if not, can you please check with @yualan / @dzsquared that there is nothing additional required in updating third part notice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted with CELA per their recommendation, and we're all clear.

@udeeshagautam
Copy link
Contributor

Build fails with this - looks you need to cpoy d.ts of xml formatter in extension

extensions/sql-database-projects/src/models/project.ts(10,28): Could not find a declaration file for module 'xml-formatter'. 'D:/a/1/s/extensions/sql-database-projects/node_modules/xml-formatter/index.js' implicitly has an 'any' type.
Try npm install @types/xml-formatter if it exists or add a new declaration (.d.ts) file containing declare module 'xml-formatter';

@Benjin
Copy link
Contributor Author

Benjin commented Jun 10, 2020

@udeeshagautam That last commit was the result of running npm install @types/xml-formatter, so I must still be missing something. Everything's building locally, so I must have some state that's cached that agents don't yet. I'll try a few things to get that .d.ts file.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 34.419% when pulling 05ab8b4 on benjin/xmlPrettify into c8a3fbc on master.

@Benjin Benjin merged commit 5ab6d3d into master Jun 11, 2020
@Benjin Benjin deleted the benjin/xmlPrettify branch June 24, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML coming out of ADS extension needs to be prettified
4 participants