-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format sqlproj file XML on serialization #10818
Conversation
extensions/sql-database-projects/src/test/baselines/SSDTProjectAfterUpdateBaseline.xml
Show resolved
Hide resolved
@@ -2225,6 +2227,51 @@ EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
========================================= | |||
END OF winreg NOTICES AND INFORMATION | |||
|
|||
%% xmldom NOTICES AND INFORMATION BEGIN HERE | |||
========================================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you already have great, if not, can you please check with @yualan / @dzsquared that there is nothing additional required in updating third part notice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chatted with CELA per their recommendation, and we're all clear.
Build fails with this - looks you need to cpoy d.ts of xml formatter in extension extensions/sql-database-projects/src/models/project.ts(10,28): Could not find a declaration file for module 'xml-formatter'. 'D:/a/1/s/extensions/sql-database-projects/node_modules/xml-formatter/index.js' implicitly has an 'any' type. |
@udeeshagautam That last commit was the result of running |
Fixes #10772