Fix deployment warnings to only show if no resources found #10878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
alanrenmsft,
llali,
ranasaria and
udeeshagautam
llali
reviewed
Jun 11, 2020
| private azurecoreApi: azurecore.IExtension | undefined; | ||
|
|
||
| public async getAzurecoreApi(): Promise<azurecore.IExtension> { | ||
| if (!this.azurecoreApi) { |
There was a problem hiding this comment.
this won't wont return error for when user doesn't have access to tenant like the previous one did?
There was a problem hiding this comment.
What do you mean? This method is just getting the azurecore API through which you call getSubscriptions/getResourceGroups. Those calls are unchanged functionality-wise.
There was a problem hiding this comment.
hmm ok my mistake, I thought those were in different extension and you're using new APIs.
There was a problem hiding this comment.
They are in a different extension (azurecore)
alanrenmsft
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9651
Now we only display an error if we didn't get any resource groups/subscriptions from these calls.
I also took this opportunity to move the functions from commands to being actual API calls.
The azdata change is non-breaking, this was something that was already true and so this is just making it so the actual API has the expected return type.