Fix for #10779 to clean build to work in SSDT post ADS build #10882
Conversation
udeeshagautam
changed the title
| const afterCleanNode = this.projFileXmlDoc.documentElement.getElementsByTagName(constants.Target)[i]; | ||
| const name = afterCleanNode.getAttribute(constants.Name); | ||
| if (name === constants.AfterCleanTarget) { | ||
| return await this.createCleanFileNode(afterCleanNode); |
There was a problem hiding this comment.
is this adding another Clean file node even if one already gets found?
There was a problem hiding this comment.
no no, if it finds AfterClean target - it adds a child to it to add the clean file node. if it does not find an after clean target - then it adds the target and then adds the child. Actually just writing a test on that :) will send shortly.
There was a problem hiding this comment.
ah ok I was initially confused because I didn't realize this was only called the one time the project gets updated for round tripping from SSDT
| const afterCleanNode = this.projFileXmlDoc.documentElement.getElementsByTagName(constants.Target)[i]; | ||
| const name = afterCleanNode.getAttribute(constants.Name); | ||
| if (name === constants.AfterCleanTarget) { | ||
| return await this.createCleanFileNode(afterCleanNode); |
There was a problem hiding this comment.
ah ok I was initially confused because I didn't realize this was only called the one time the project gets updated for round tripping from SSDT
This PR fixes ##10779
This was happening to due generated assests.json - adding a after clean target for the same to be called at rebuild and clean tasks.