Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error logging when fetching account provider accounts #13082

Merged
merged 3 commits into from
Oct 26, 2020

Conversation

Charles-Gagnon
Copy link
Contributor

For #11260 - it's not clear where the issue is coming from but if it's here this would silently just be failing so adding logging to see if that helps track down what's happening.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 330054111

  • 10 of 12 (83.33%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 39.811%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sql/platform/accounts/common/accountViewModel.ts 10 12 83.33%
Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/jupyter/serverInstance.ts 4 73.61%
Totals Coverage Status
Change from base Build 329900188: -0.002%
Covered Lines: 20594
Relevant Lines: 47477

💛 - Coveralls

@Charles-Gagnon Charles-Gagnon merged commit c2bd11f into main Oct 26, 2020
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/addAccountLogging branch October 26, 2020 23:06
Benjin pushed a commit that referenced this pull request Oct 30, 2020
* Add error logging when fetching account provider accounts

* fix test

* fix tests #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants