Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebooks: Fix pip installation not working #14506

Merged
merged 6 commits into from
Mar 4, 2021
Merged

Notebooks: Fix pip installation not working #14506

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f779c6
upgrade pip after python installation
lucyzhang929 Mar 2, 2021
a8bca0a
add comment
lucyzhang929 Mar 2, 2021
5484c35
only upgrade pip for new python installations
lucyzhang929 Mar 3, 2021
e9ed663
reinstall pip version instead of upgrade to latest
lucyzhang929 Mar 3, 2021
42f1e9e
update comment
lucyzhang929 Mar 3, 2021
4e1f420
get pip version through packages list
lucyzhang929 Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions extensions/notebook/src/jupyter/jupyterServerInstallation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,9 @@ export class JupyterServerInstallation implements IJupyterServerInstallation {
if (!pythonExists || forceInstall) {
await this.installPythonPackage(backgroundOperation, this._usingExistingPython, this._pythonInstallationPath, this.outputChannel);
}
// upgrade pip to make sure the right version is installed
let cmd = `"${this._pythonExecutable}" -m pip install --upgrade pip`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this only affects the New Install option, should we skip this upgrade when _usingExistingPython is true? We wouldn't want to force upgrade a user's pip packages as a side effect of another install.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes sense.

await this.executeBufferedCommand(cmd);
await this.upgradePythonPackages(forceInstall, packages);
} catch (err) {
this.outputChannel.appendLine(msgDependenciesInstallationFailed(utils.getErrorMessage(err)));
Expand Down