-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use {arg} to reference selected text in query shortcuts #14894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me. @alanrenmsft what do you think?
src/sql/workbench/contrib/query/browser/keyboardQueryActions.ts
Outdated
Show resolved
Hide resolved
@mejiaej could you please make the update @Charles-Gagnon suggests regarding doing a global replace? Thanks! |
@kburtram can do, I'll do it later today. I'm on working hours right now 😂 |
@mejiaej thanks! no rush. It would be good to have that update before we can merge. |
My goal is to add the ability to insert the parameter anywhere in the query. I'm modifying the execution of query shortcuts by first checking if
{arg}
is present, if true just replace it with the parameter if not add the parameter at the end of the query just like it's been working until now.This PR fixes #14893