Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to extensions gallery json with upcoming language pack update #14924

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

smartguest
Copy link
Contributor

No description provided.

Copy link
Member

@kburtram kburtram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths for the BLOBs (at least https://sqlopsextensions.blob.core.windows.net/extensions/langpacks/1.26.0/ads-language-pack-de-1.26.0.vsix) didn't resolve to a file on the BLOB storage. We should have the VSIX files staged prior to updating the gallery file.

@smartguest
Copy link
Contributor Author

I uploaded the Vsix files to the BLOB storage, I'm not sure if there are any further steps that I needed to do before that, but the BLOB paths should work now. @kburtram

@Charles-Gagnon
Copy link
Contributor

Where did you get these VSIXs from? We should only be uploading VSIXs that come from an official product build pipeline (and per our new release process, from a release branch specifically for stable extension updates)

@smartguest
Copy link
Contributor Author

They were generated by me @Charles-Gagnon but I'll remove those from the SQL blob storage right now, the update extension gallery process readme document is very vague and does not at all mention how to do this.

@Charles-Gagnon
Copy link
Contributor

Thanks. Do we have the process for building and updating these langpack extensions documented anywhere? That would be great to have so that we don't have to rely on people already knowing what to do to update these.

Alan Ren is working on updating the extension release process docs - I'll work with him to make sure that it's clear where the VSIX's come from.

@smartguest
Copy link
Contributor Author

smartguest commented Mar 31, 2021

@Charles-Gagnon We do not currently have one specifically tailored for ADS, but for vscode-loc, it is listed: https://github.com/Microsoft/vscode-loc/wiki/How-to-create-language-pack-extension . The issue is that translations have to be pulled in manually for ADS instead of using Transifex. I have written a document that goes over the process of manually converting a vscode lang pack into an ADS compatible one. The vscode-loc repository also has instructions on how to publish to the marketplace but I don't think I should follow that for our language packs.

@smartguest
Copy link
Contributor Author

@Charles-Gagnon The language pack has been merged in and the vsix files have been uploaded to the blob storage. On the insiders build, attempting to access any language pack results in an XHR error, I'm wondering if the gallery files need to be updated to fix this error, the vsix packages work on their own.

@Charles-Gagnon
Copy link
Contributor

Charles-Gagnon commented Apr 2, 2021

Yeah, so this broke with your latest changes because you modified the langpack paths. The galleries are pointing to resource URLs such as https://raw.githubusercontent.com/microsoft/azuredatastudio/main/i18n/language-pack-es/languagepack.png which no longer exist.

So we have a couple ways to fix this :

  1. Just update the current gallery files with the new paths (leave them pointing at the 1.9.0 versions)
  2. Finish this PR and publish the updated galleries with the new 1.26.0 versions

2 would be best if those are ready to go, but I still am wondering where you got those VSIXs from since AFAIK none of our pipelines generate the langpack VSIXs

@Charles-Gagnon
Copy link
Contributor

In case you didn't see my other PR I pushed a fix for the galleries to fix the broken links while we discuss the new version of the extensions.

@smartguest
Copy link
Contributor Author

smartguest commented Apr 2, 2021

@Charles-Gagnon They were generated locally using VSCE package directly and were approved to be merged in. The pipeline does not generate them at all. Also the gallery files are ready to go (fixed the conflicts).

@smartguest smartguest merged commit bea6526 into release/extensions Apr 7, 2021
@smartguest smartguest deleted the alex/updateforlangpackgallery branch April 7, 2021 20:33
smartguest added a commit that referenced this pull request Apr 7, 2021
@smartguest smartguest restored the alex/updateforlangpackgallery branch April 7, 2021 21:02
Charles-Gagnon pushed a commit that referenced this pull request Apr 7, 2021
abist pushed a commit that referenced this pull request Apr 8, 2021
* Update Arc & Azdata extensions - Insiders (#14990)

* Validate galleries for RC1 branch as well (#14994)

* Update to extensions gallery json with upcoming language pack update (#14924)

* Revert "Update to extensions gallery json with upcoming language pack update (#14924)" (#15032)

This reverts commit bea6526.

* Update azdata to latest - insiders (#15034)

* Update CODEOWNERS (#15038)

DRI

* Update Kusto to 0.5.2 (#14959)

* Updated Kusto version to 0.5.2.

* Updated minimum AzDataEngine version

* Update version of schema visualization (#15051)

Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Justin M <63619224+JustinMDotNet@users.noreply.github.com>
Co-authored-by: Jens Hunt <himself@jenshunt.se>
abist pushed a commit that referenced this pull request Apr 13, 2021
* Update Arc & Azdata extensions - Insiders (#14990)

* Validate galleries for RC1 branch as well (#14994)

* Update to extensions gallery json with upcoming language pack update (#14924)

* Revert "Update to extensions gallery json with upcoming language pack update (#14924)" (#15032)

This reverts commit bea6526.

* Update azdata to latest - insiders (#15034)

* Update CODEOWNERS (#15038)

DRI

* Update Kusto to 0.5.2 (#14959)

* Updated Kusto version to 0.5.2.

* Updated minimum AzDataEngine version

* Update version of schema visualization (#15051)

* Submitted a new extension to the gallery (#14926)

* Submitted a new extension to the gallery

The extension submitted is "SQL Data Inspector" (sql-data-inspector).

* Fixed TotalCount in the extensions gallery.

* Added extension sql-data-inspector to the insider gallery.
Added Microsoft.AzDataEngine property to the extension sql-data-inspector.

* Updated version for extension "sql-data-inspector" to v0.1.1.

* Changed extension description and updated version to "0.1.2"

Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Justin M <63619224+JustinMDotNet@users.noreply.github.com>
Co-authored-by: Jens Hunt <himself@jenshunt.se>
Co-authored-by: Ernesto Cianciotta <ernesto.cianciotta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants