Fix notebook icons #15346
Merged
Fix notebook icons #15346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucyzhang929 how about actions that are contributed by extensions (Manage Packages, Convert to SQL script)? |
halerankin
approved these changes
May 6, 2021
|
@chlafreniere Those icons weren't affected by the viewBox change because those SVG files were not converted to inline (instead the url is just the path to the SVG file). I'm not sure why only the notebook core icons are converted to inline. @halerankin do you have any ideas? Might be related to the masked-icon work. |
Pull Request Test Coverage Report for Build 817610706
💛 - Coveralls |
VasuBhog
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #15281
With the recent update in the svgo package, the removeViewBox plugin is defaulted to true, removing viewBox when converting SVGs to inline and causing the notebook icons to not render properly. The removeViewBox plugin only removes viewBox if width and height are also defined. Removing width and height from the SVGs allows the viewBox to be kept and the icons to be rendered correctly.
More discussion about the issue: svg/svgo#1128 (comment)