Set target platform for db projects from server metadata: mssql vscode extension #20607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakshiS-harma
requested review from
VasuBhog,
Charles-Gagnon,
lucyzhang929,
chlafreniere and
MaddyDev
as code owners
Pull Request Test Coverage Report for Build 3084432698
💛 - Coveralls |
kisantia
reviewed
Sep 15, 2022
extensions/sql-database-projects/src/controllers/projectController.ts
Outdated
Show resolved
Hide resolved
kisantia
approved these changes
Sep 16, 2022
Charles-Gagnon
requested changes
Sep 16, 2022
Charles-Gagnon
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #20576.
Read server metadata sent from mssql-vscode extension to set target platform automatically when creating project from database.