Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple Silicon build and Universal build for macOS #20776

Merged
merged 37 commits into from
Oct 11, 2022

Conversation

alanrenmsft
Copy link
Contributor

@alanrenmsft alanrenmsft commented Oct 9, 2022

In this PR, I updated the build scripts/pipeline definitions to produce builds for Apple Silicon and Universal App that runs on both Intel Chip and Apple Silicon.
build for testing: https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=174262&view=results

I'd like to get the insider version out and ask the users to try it out before the Nov release. In the meanwhile, I will continue working on these tasks that are related but not blocking:
#20792
#20775

Testing:

  1. The main features like connection, azure, query editor, notebook, OE, dashboard, dacpac, schema compare...
  2. The release process: newly produced files can be handled by the update server, I was able to download them during my testing. I'll work with Erica to get the new links added to the release process.

Also noticed that the Notebook Python kernel is not working on M1 regardless of the ADS flavor that I use, tried all 3 flavors, but it is not a new issue: #18186
@chlafreniere please let me know if you need a M1 mac to fix the issue.

@coveralls
Copy link

coveralls commented Oct 9, 2022

Pull Request Test Coverage Report for Build 3223120770

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.004%) to 42.345%

Files with Coverage Reduction New Missed Lines %
src/sql/workbench/services/connection/browser/connectionManagementService.ts 7 70.94%
src/sql/workbench/contrib/commandLine/electron-browser/commandLine.ts 20 72.65%
Totals Coverage Status
Change from base Build 3208267175: -0.004%
Covered Lines: 29389
Relevant Lines: 64576

💛 - Coveralls

@alanrenmsft alanrenmsft marked this pull request as ready for review October 10, 2022 20:13
build/azure-pipelines/sql-product-build.yml Show resolved Hide resolved
build/darwin/create-universal-app.ts Outdated Show resolved Hide resolved
extensions/mssql/config.json Outdated Show resolved Hide resolved
@alanrenmsft alanrenmsft merged commit ee2905d into main Oct 11, 2022
@alanrenmsft alanrenmsft deleted the alanren/macos-arm64 branch October 11, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants