-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Apple Silicon build and Universal build for macOS #20776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3223120770
💛 - Coveralls |
build/azure-pipelines/darwin/sql-product-build-darwin-universal.yml
Outdated
Show resolved
Hide resolved
Charles-Gagnon
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I updated the build scripts/pipeline definitions to produce builds for Apple Silicon and Universal App that runs on both Intel Chip and Apple Silicon.
build for testing: https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=174262&view=results
I'd like to get the insider version out and ask the users to try it out before the Nov release. In the meanwhile, I will continue working on these tasks that are related but not blocking:
#20792
#20775
Testing:
Also noticed that the Notebook Python kernel is not working on M1 regardless of the ADS flavor that I use, tried all 3 flavors, but it is not a new issue: #18186
@chlafreniere please let me know if you need a M1 mac to fix the issue.