-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit for Query Store extension #23260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good aside from the one eslint thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion on whether we should let this merged into main since no functionality has been introduced. usually I'd recommend to create a feature branch so that the changes can be reviewed in smaller PRs and merge it to main when the planned features are implemented.
I can change this to target a feature branch if that's preferred, but thought this would be ok to go into main since it's a separate extension and won't be included in a release until it's uploaded in the extensions gallery. |
@kisantia that is why I don't have a strong opinion, feel free to merge to main.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work item for tracking: https://powerbi.visualstudio.com/Trident/_workitems/edit/1110640
@kisantia this commit caused 2 dependBot alerts, I took a look at them and realized you might have copied the yarn.lock file from another extension, to make it accurate, could you please regenerate the yarn.lock so that it only contains the packages that are actually being used? |
@kisantia I'll do it, a pr will be out shortly. |
Thanks @alanrenmsft! Forgot to regenerate it after removing the unused dependencies in package.json in an earlier commit in this PR |
Initial commit for the Query Store extension. No functionality added, just the bare bones code needed to build the new extension.