-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding database properties general tab with read-only fields #23318
Changes from all commits
ca43ade
ca0ad70
1a9094a
84d24c7
54ebf98
8733af8
10beedc
8caf792
09475f1
cfbabdf
cd2feb5
8be6593
1cf0f50
86585b1
31e4532
552a35e
1bbc647
7a112c7
38844ce
9465829
03217e6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,3 +42,8 @@ export function isValidSQLPassword(password: string, userName: string = 'sa'): b | |
const hasNonAlphas = /\W/.test(password) ? 1 : 0; | ||
return !containsUserName && password.length >= 8 && password.length <= 128 && (hasUpperCase + hasLowerCase + hasNumbers + hasNonAlphas >= 3); | ||
} | ||
|
||
// Converts number to two decimal placed string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use actual JS doc syntax for doc comments please |
||
export function convertNumToTwoDecimalStringinMB(value: number): string { | ||
return localizedConstants.StringValueInMB(value?.toFixed(2)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If value is actually possible to be undefined then the parameter should reflect that. And in that case it'd probably be better to just return an empty string instead |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about updating getParentUrn to possibly return undefined instead? That makes sense if there isn't a parent already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if the ParentUrn is empty, then can we cconsider the objectUrn as a parent and update the value there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this as a follow-up - I already asked @barbaravaldez to do a separate PR for moving this into a helper function anyways and we can discuss it there.