Initial changes for reusable QDS report #23527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export async function activate(_context: vscode.ExtensionContext): Promise<void> { | ||
| export async function activate(context: vscode.ExtensionContext): Promise<void> { | ||
| // TODO: get db name | ||
| context.subscriptions.push(vscode.commands.registerCommand('queryStore.topResourceConsumingQueriesOpen', async () => { await new TopResourceConsumingQueries(context, 'WideWorldImporters').open() })); |
There was a problem hiding this comment.
Nit: Declare a const with the hardcoded database name below the TODO.
There was a problem hiding this comment.
the database name/connection profile will later get passed into the command from where the command is launched from, so it'll look like context.subscriptions.push(vscode.commands.registerCommand('queryStore.topResourceConsumingQueriesOpen', async (profile: azdata.IConnectionProfile) => { await new TopResourceConsumingQueries(context, profile).open() }));
aasimkhan30
approved these changes
Jun 28, 2023
lewis-sanchez
approved these changes
Jun 29, 2023
cssuh
pushed a commit
that referenced
this pull request
Jun 30, 2023
* initial changes for making a QDS report with placeholders * Add icon for configure button * Add another example report to show layout * move files * add placeholder names to components and cleanup toolbar * cleanup * switch to createViews() instead of createTop and BottomSections() * add QueryStoreView class for the different components in a report * cleanup * add more comments * fix yarn not running for query store extension folder * add missing break * change one more view to container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the initial changes for building a reusable report in the QDS extension using Modelview components. The two placeholder reports being added in this PR are Overall Resource Consumption and Top Resource Consuming Queries. Right now it has placeholder text components in flex containers to show the different sections in the reports, but those will be replaced with chart/table/query plan components in the future.
The entry points for these reports are currently commands in the command palette. Updating the reports to be opened with the context of a database is a task for later
The
BaseQueryStoreReportclass supports resizable components by using splitviews, and also supports building non-resizeable reports (for example, the Overall Resource Consumption report is not resizable in SSMS).