Add chromium license to Azure Data Studio #23528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis-sanchez
commented
Jun 28, 2023
| @@ -1,19 +0,0 @@ | |||
| [package] | |||
There was a problem hiding this comment.
Not entirely sure what this file is all about, but it kept showing up as a deleted file that was appearing in local file directory.
kburtram
reviewed
Jun 28, 2023
They said it could either be a separate file or appended to the product’s NOTICE file. I can move it into a notice file if that's preferred. |
kisantia
reviewed
Jun 29, 2023
build/win32/cargo.toml
Outdated
There was a problem hiding this comment.
This file was previously added in #20853 to fix a vulnerability. Can you please double check this is no longer needed before deleting it? Especially since it doesn't seem related to adding the chromium license
lewis-sanchez
force-pushed
the
lewissanchez/updateLicensing
branch
from
4151748
to
4c1312d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a chromium license to the Azure Data Studio repo.