Remove dashboard color overrides #23533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
force-pushed
the
cheena/fix-dashboard
branch
from
f8dac4c
to
3bbbf51
Compare
kburtram
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
LGTM but @alanrenmsft been driving the styling fixes and would have better context.
Charles-Gagnon
approved these changes
Jun 29, 2023
alanrenmsft
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23521
Dashboard widget's
updateThemewas going against theme color scheme by setting 'NULL' color (SIDE_BAR_FOREGROUND), which now has a default dull color, that causes accessibility issues. PR fixes issue by removing color overrides to keep text/background color in sync with theme.