Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo the table styles #23538

Merged
merged 9 commits into from
Jun 29, 2023
Merged

redo the table styles #23538

merged 9 commits into from
Jun 29, 2023

Conversation

alanrenmsft
Copy link
Contributor

No description provided.

@alanrenmsft alanrenmsft merged commit dec8114 into main Jun 29, 2023
6 checks passed
@alanrenmsft alanrenmsft deleted the alanren/table-style branch June 29, 2023 05:19
@Charles-Gagnon
Copy link
Contributor

Out of curiosity - what happened here? You said "redo", so were these removed during the merge for some reason? Or did VS Code change how theming stuff is done?

@alanrenmsft
Copy link
Contributor Author

@Charles-Gagnon VSCode is now using the css variable instead of changing the color on the element when theme changes, when the theme changes, vscode will update the variable values so that the old attachStyler is no longer needed.

cssuh pushed a commit that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants