Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue updating installed extension list #23556

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Fix issue updating installed extension list #23556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/vs/workbench/contrib/extensions/browser/extensionsViews.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,13 @@ export class ExtensionsListView extends ViewPane {
}

count(): number {
return this.queryResult?.model.length ?? 0;
// {{SQL CARBON EDIT}} - try to use the list model before the queryResult model
// {{SQL CARBON EDIT}} - since there are code paths that call updateModel without updating queryResults
if (this.list?.model) {
return this.list.model.length;
} else {
return this.queryResult?.model.length ?? 0;
}
}

protected showEmptyModel(): Promise<IPagedModel<IExtension>> {
Expand Down