Adds chromium license #23560
Merged
Adds chromium license #23560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since there aren't any other licenses as separate files in the ADS repo, I feel like it would be less confusing to append this to the 3rd party notices file. |
kisantia
reviewed
Jun 29, 2023
ThirdPartyNotices.txt
Outdated
| OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
| -------------------------------END OF THIRD-PARTY NOTICES------------------------------------------- | ||
|
|
||
| ========================================= | ||
| END OF Microsoft.ProgramSynthesis.Detection NOTICES AND INFORMATION |
There was a problem hiding this comment.
should the chromium notice be added after this line stating the END OF Microsoft.ProgramSynthesis.Detection NOTICES AND INFORMATION?
kisantia
reviewed
Jun 29, 2023
kisantia
approved these changes
Jun 29, 2023
cssuh
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Adds chromium license * Moves chromium license to notices file * Relocates chromium notice in file * Removes extra whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a chromium license to the Azure Data Studio repo. Directions to add the license specified that it could either be a separate file or appended to ADS's NOTICE file.