Fix missing telemetry opt out toast #23570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
changed the title
kburtram
approved these changes
Jun 29, 2023
alanrenmsft
approved these changes
Jun 29, 2023
cssuh
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Fix telemetry opt out toast * fix imports * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was actually broken in the previous merge - the bootstrap module that loaded the telemetry opt out contribution was deleted and the import was never moved to the new one.
While fixing this I noticed that VS Code has removed the toast notification and moved to just having it inline on their welcome page.
So I went ahead and moved the files to the sql folder since they don't exist in the vs folder anymore. (since we use a custom welcome page we don't have the same link show up, and for now there aren't any plans to change that)
I also deleted the workspaceTrust.svg, which were left over from a previous merge. The icon was moved to https://github.com/Microsoft/azuredatastudio/blob/main/src/vs/workbench/contrib/welcomeGettingStarted/common/media/workspaceTrust.svg so the ones in the welcome folder should have been deleted at that point.
(I have also added a manual test case to our test plan so we don't miss this breaking again)
After :