Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown behavior #23708

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix dropdown behavior #23708

merged 1 commit into from
Jul 10, 2023

Conversation

cssuh
Copy link
Member

@cssuh cssuh commented Jul 8, 2023

Account Picker Dropdown in the Firewall Rule Dialog was not expanding when clicked, this fixes that issue.

Fixes: #23707

@cssuh cssuh requested a review from cheenamalhotra July 8, 2023 15:47
@@ -79,7 +79,7 @@ export class Dropdown extends BaseDropdown {
}
}

export class DropdownList extends BaseDropdown {
export class DropdownList extends Dropdown {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this with other places that use the control (if any) to make sure the behavior there is still working correctly?

Is this something that broke in the merge?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was - @kburtram do you recall why this was changed to extend BaseDropdown? Let's make sure we're not regressing something else that necessitated that change in the first place.

@cssuh cssuh merged commit 95599ae into main Jul 10, 2023
@cssuh cssuh deleted the chsuh/dropdownFix branch July 10, 2023 21:59
cssuh added a commit that referenced this pull request Jul 11, 2023
kisantia pushed a commit that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firewall Rule Dialog AccountPicker not expanding
3 participants