Fix dropdown behavior #23708
Merged
Fix dropdown behavior #23708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,7 +79,7 @@ export class Dropdown extends BaseDropdown { | |||
| } | |||
| } | |||
|
|
|||
| export class DropdownList extends BaseDropdown { | |||
| export class DropdownList extends Dropdown { | |||
There was a problem hiding this comment.
Have you tested this with other places that use the control (if any) to make sure the behavior there is still working correctly?
Is this something that broke in the merge?
There was a problem hiding this comment.
Looks like it was - @kburtram do you recall why this was changed to extend BaseDropdown? Let's make sure we're not regressing something else that necessitated that change in the first place.
cheenamalhotra
approved these changes
Jul 10, 2023
cssuh
added a commit
that referenced
this pull request
Jul 11, 2023
kisantia
pushed a commit
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account Picker Dropdown in the Firewall Rule Dialog was not expanding when clicked, this fixes that issue.
Fixes: #23707