Skip flaky vscode test suites #23712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think there's much value in disabling single tests anymore. This issue doesn't seem to have any relation to the actual test being ran so could happen for any test (or at least a large enough quantity that disabling them one-by-one doesn't seem to be helping much). (for example the PR run for this PR itself has a failure for the same reason) |
|
Makes sense, I will discard this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These suites are intermittently being impacted by the xterm glyph issue. Plan is to reenable after further investigation and stabilization.
Tracked by issue #23509.