Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limit on the file size that can be opened with Open XEL feature #23840

Closed
wants to merge 7 commits into from
Closed

Add limit on the file size that can be opened with Open XEL feature #23840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
949dddf
Update profiler version and related azdata dependency (#23739)
SakshiS-harma Jul 10, 2023
1a52c8b
[Loc] added translated getting started to langpack (#23744) (#23746)
smartguest Jul 10, 2023
a002a8c
fix dropdown behavior (#23708) (#23772)
cssuh Jul 11, 2023
94899e6
Create new context menu item for Database (#23771) (#23774)
barbaravaldez Jul 11, 2023
034d818
Limit Detach Database and Database/Server Properties to insiders and …
corivera Jul 11, 2023
ba8d153
Update vscode version for Profiler extension (#23767)
SakshiS-harma Jul 11, 2023
e7a5211
Add limit on the file size that can be opened with Open XEL feature
SakshiS-harma Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 36 additions & 6 deletions extensions/mssql/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@
"title": "%title.newObject%",
"icon": "$(add)"
},
{
"command": "mssql.newDatabase",
"category": "MSSQL",
"title": "%title.newDatabase%",
"icon": "$(add)"
},
{
"command": "mssql.objectProperties",
"category": "MSSQL",
Expand Down Expand Up @@ -490,6 +496,10 @@
"command": "mssql.newObject",
"when": "false"
},
{
"command": "mssql.newDatabase",
"when": "false"
},
{
"command": "mssql.objectProperties",
"when": "false"
Expand Down Expand Up @@ -526,12 +536,22 @@
},
{
"command": "mssql.newObject",
"when": "connectionProvider == MSSQL && nodeType == Folder && objectType =~ /^(ServerLevelLogins|Users|ServerLevelServerRoles|ApplicationRoles|DatabaseRoles|Databases)$/ && config.workbench.enablePreviewFeatures",
"when": "connectionProvider == MSSQL && nodeType == Folder && objectType =~ /^(ServerLevelLogins|Users|ServerLevelServerRoles|ApplicationRoles|DatabaseRoles)$/ && config.workbench.enablePreviewFeatures",
"group": "1_objectManagement@0"
},
{
"command": "mssql.newObject",
"when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|ServerLevelServerRole|ApplicationRole|DatabaseRole|Database)$/ && !(nodePath =~ /^.*\\/System Databases\\/.*$/) && config.workbench.enablePreviewFeatures",
"when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|ServerLevelServerRole|ApplicationRole|DatabaseRole)$/ && !(nodePath =~ /^.*\\/System Databases\\/.*$/) && config.workbench.enablePreviewFeatures",
"group": "1_objectManagement@0"
},
{
"command": "mssql.newDatabase",
"when": "connectionProvider == MSSQL && nodeType == Folder && objectType == Databases && config.workbench.enablePreviewFeatures",
"group": "1_objectManagement@0"
},
{
"command": "mssql.newDatabase",
"when": "connectionProvider == MSSQL && nodeType == Database && !(nodePath =~ /^.*\\/System Databases\\/.*$/) && config.workbench.enablePreviewFeatures",
"group": "1_objectManagement@0"
},
{
Expand All @@ -546,7 +566,7 @@
},
{
"command": "mssql.detachDatabase",
"when": "connectionProvider == MSSQL && nodeType == Database && !isCloud && !(nodePath =~ /^.*\\/System Databases\\/.*$/) && config.workbench.enablePreviewFeatures",
"when": "connectionProvider == MSSQL && nodeType == Database && !isCloud && !(nodePath =~ /^.*\\/System Databases\\/.*$/) && config.workbench.enablePreviewFeatures && (productQualityType =~ /^(insider|dev)$/ || isDevelopment)",
"group": "1_objectManagement@2"
},
{
Expand All @@ -567,7 +587,7 @@
},
{
"command": "mssql.objectProperties",
"when": "connectionProvider == MSSQL && serverInfo && !isCloud && nodeType && nodeType =~ /^(Database|Server)$/ && mssql:engineedition != 11 && config.workbench.enablePreviewFeatures",
"when": "connectionProvider == MSSQL && serverInfo && !isCloud && nodeType =~ /^(Database|Server)$/ && mssql:engineedition != 11 && config.workbench.enablePreviewFeatures && (productQualityType =~ /^(insider|dev)$/ || isDevelopment)",
"group": "z_objectexplorer@3"
},
{
Expand Down Expand Up @@ -613,12 +633,22 @@
},
{
"command": "mssql.newObject",
"when": "connectionProvider == MSSQL && nodeType == Folder && objectType =~ /^(ServerLevelLogins|Users|ServerLevelServerRoles|ApplicationRoles|DatabaseRoles|Databases)$/ && config.workbench.enablePreviewFeatures",
"when": "connectionProvider == MSSQL && nodeType == Folder && objectType =~ /^(ServerLevelLogins|Users|ServerLevelServerRoles|ApplicationRoles|DatabaseRoles)$/ && config.workbench.enablePreviewFeatures",
"group": "1_objectManagement@0"
},
{
"command": "mssql.newObject",
"when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|ServerLevelServerRole|ApplicationRole|DatabaseRole|Database)$/ && !(nodePath =~ /^.*\\/System Databases\\/.*$/) && config.workbench.enablePreviewFeatures",
"when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|ServerLevelServerRole|ApplicationRole|DatabaseRole)$/ && !(nodePath =~ /^.*\\/System Databases\\/.*$/) && config.workbench.enablePreviewFeatures",
"group": "1_objectManagement@0"
},
{
"command": "mssql.newDatabase",
"when": "connectionProvider == MSSQL && nodeType == Folder && objectType == Databases && config.workbench.enablePreviewFeatures",
"group": "1_objectManagement@0"
},
{
"command": "mssql.newDatabase",
"when": "connectionProvider == MSSQL && nodeType == Database && !(nodePath =~ /^.*\\/System Databases\\/.*$/) && config.workbench.enablePreviewFeatures",
"group": "1_objectManagement@0"
},
{
Expand Down
1 change: 1 addition & 0 deletions extensions/mssql/package.nls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@
"mssql.objectExplorer.disableGroupBySchemaTitle": "SQL Server: Disable Group By Schema",
"mssql.objectExplorer.expandTimeout": "The timeout in seconds for expanding a node in Object Explorer. The default value is 45 seconds.",
"title.newObject": "New (Preview)",
"title.newDatabase": "New Database (Preview)",
"title.objectProperties": "Properties (Preview)",
"title.deleteObject": "Delete (Preview)",
"title.renameObject": "Rename (Preview)",
Expand Down
3 changes: 3 additions & 0 deletions extensions/mssql/src/objectManagement/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ export function registerObjectManagementCommands(appContext: AppContext) {
appContext.extensionContext.subscriptions.push(vscode.commands.registerCommand('mssql.newObject', async (context: azdata.ObjectExplorerContext) => {
await handleNewObjectDialogCommand(context, service);
}));
appContext.extensionContext.subscriptions.push(vscode.commands.registerCommand('mssql.newDatabase', async (context: azdata.ObjectExplorerContext) => {
await handleNewObjectDialogCommand(context, service);
}));
appContext.extensionContext.subscriptions.push(vscode.commands.registerCommand('mssql.objectProperties', async (context: azdata.ObjectExplorerContext) => {
await handleObjectPropertiesDialogCommand(context, service);
}));
Expand Down
5 changes: 3 additions & 2 deletions extensions/profiler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@
"name": "profiler",
"displayName": "%displayName%",
"description": "%description%",
"version": "0.13.0",
"version": "0.14.0",
"publisher": "Microsoft",
"preview": true,
"license": "https://raw.githubusercontent.com/Microsoft/azuredatastudio/main/LICENSE.txt",
"icon": "images/extension.png",
"engines": {
"vscode": "0.10.0"
"vscode": "*",
"azdata": ">=1.45.0"
},
"activationEvents": [
"*"
Expand Down
4 changes: 2 additions & 2 deletions i18n/ads-language-pack-de/translations/main.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14606,8 +14606,8 @@
"enablePreviewFeatures.yes": "Ja (empfohlen)"
},
"sql/workbench/contrib/welcome/gettingStarted/electron-browser/gettingStarted": {
"miGettingStarted": "Getting &&Started",
"showReleaseNotes": "Show Getting Started"
"miGettingStarted": "Erste &&Schritte",
"showReleaseNotes": "\"Erste Schritte\" anzeigen"
},
"sql/workbench/contrib/welcome/page/browser/az_data_welcome_page": {
"welcomePage.createConnection": "Verbindung erstellen",
Expand Down
4 changes: 2 additions & 2 deletions i18n/ads-language-pack-es/translations/main.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14606,8 +14606,8 @@
"enablePreviewFeatures.yes": "Sí (opción recomendada)"
},
"sql/workbench/contrib/welcome/gettingStarted/electron-browser/gettingStarted": {
"miGettingStarted": "Getting &&Started",
"showReleaseNotes": "Show Getting Started"
"miGettingStarted": "I&&ntroducción",
"showReleaseNotes": "Ver introducción"
},
"sql/workbench/contrib/welcome/page/browser/az_data_welcome_page": {
"welcomePage.createConnection": "Crear una conexión",
Expand Down
4 changes: 2 additions & 2 deletions i18n/ads-language-pack-fr/translations/main.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14606,8 +14606,8 @@
"enablePreviewFeatures.yes": "Oui (recommandé)"
},
"sql/workbench/contrib/welcome/gettingStarted/electron-browser/gettingStarted": {
"miGettingStarted": "Getting &&Started",
"showReleaseNotes": "Show Getting Started"
"miGettingStarted": "Pri&&se en main",
"showReleaseNotes": "Afficher la mise en route"
},
"sql/workbench/contrib/welcome/page/browser/az_data_welcome_page": {
"welcomePage.createConnection": "Créer une connexion",
Expand Down
4 changes: 2 additions & 2 deletions i18n/ads-language-pack-it/translations/main.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14606,8 +14606,8 @@
"enablePreviewFeatures.yes": "Sì (scelta consigliata)"
},
"sql/workbench/contrib/welcome/gettingStarted/electron-browser/gettingStarted": {
"miGettingStarted": "Getting &&Started",
"showReleaseNotes": "Show Getting Started"
"miGettingStarted": "&&Introduzione",
"showReleaseNotes": "Mostra introduzione"
},
"sql/workbench/contrib/welcome/page/browser/az_data_welcome_page": {
"welcomePage.createConnection": "Crea una connessione",
Expand Down
4 changes: 2 additions & 2 deletions i18n/ads-language-pack-ja/translations/main.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14606,8 +14606,8 @@
"enablePreviewFeatures.yes": "はい (推奨)"
},
"sql/workbench/contrib/welcome/gettingStarted/electron-browser/gettingStarted": {
"miGettingStarted": "Getting &&Started",
"showReleaseNotes": "Show Getting Started"
"miGettingStarted": "はじめに(&&S)",
"showReleaseNotes": "「はじめに」を表示する"
},
"sql/workbench/contrib/welcome/page/browser/az_data_welcome_page": {
"welcomePage.createConnection": "接続の作成",
Expand Down
4 changes: 2 additions & 2 deletions i18n/ads-language-pack-ko/translations/main.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14606,8 +14606,8 @@
"enablePreviewFeatures.yes": "예(추천)"
},
"sql/workbench/contrib/welcome/gettingStarted/electron-browser/gettingStarted": {
"miGettingStarted": "Getting &&Started",
"showReleaseNotes": "Show Getting Started"
"miGettingStarted": "시작(&&S)",
"showReleaseNotes": "시작 표시"
},
"sql/workbench/contrib/welcome/page/browser/az_data_welcome_page": {
"welcomePage.createConnection": "연결 만들기",
Expand Down
4 changes: 2 additions & 2 deletions i18n/ads-language-pack-pt-BR/translations/main.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14606,8 +14606,8 @@
"enablePreviewFeatures.yes": "Sim (recomendado)"
},
"sql/workbench/contrib/welcome/gettingStarted/electron-browser/gettingStarted": {
"miGettingStarted": "Getting &&Started",
"showReleaseNotes": "Show Getting Started"
"miGettingStarted": "I&&ntrodução",
"showReleaseNotes": "Mostrar Introdução"
},
"sql/workbench/contrib/welcome/page/browser/az_data_welcome_page": {
"welcomePage.createConnection": "Criar uma conexão",
Expand Down
4 changes: 2 additions & 2 deletions i18n/ads-language-pack-ru/translations/main.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14606,8 +14606,8 @@
"enablePreviewFeatures.yes": "Да (рекомендуется)"
},
"sql/workbench/contrib/welcome/gettingStarted/electron-browser/gettingStarted": {
"miGettingStarted": "Getting &&Started",
"showReleaseNotes": "Show Getting Started"
"miGettingStarted": "&&Начало работы",
"showReleaseNotes": "Показать раздел \"Начало работы\""
},
"sql/workbench/contrib/welcome/page/browser/az_data_welcome_page": {
"welcomePage.createConnection": "Создать подключение",
Expand Down
4 changes: 2 additions & 2 deletions i18n/ads-language-pack-zh-hans/translations/main.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14606,8 +14606,8 @@
"enablePreviewFeatures.yes": "是(推荐)"
},
"sql/workbench/contrib/welcome/gettingStarted/electron-browser/gettingStarted": {
"miGettingStarted": "Getting &&Started",
"showReleaseNotes": "Show Getting Started"
"miGettingStarted": "入门(&&S)",
"showReleaseNotes": "显示入门指南"
},
"sql/workbench/contrib/welcome/page/browser/az_data_welcome_page": {
"welcomePage.createConnection": "创建连接",
Expand Down
4 changes: 2 additions & 2 deletions i18n/ads-language-pack-zh-hant/translations/main.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14606,8 +14606,8 @@
"enablePreviewFeatures.yes": "是 (建議)"
},
"sql/workbench/contrib/welcome/gettingStarted/electron-browser/gettingStarted": {
"miGettingStarted": "Getting &&Started",
"showReleaseNotes": "Show Getting Started"
"miGettingStarted": "使用者入門(&&S)",
"showReleaseNotes": "顯示使用者入門"
},
"sql/workbench/contrib/welcome/page/browser/az_data_welcome_page": {
"welcomePage.createConnection": "建立連線",
Expand Down
4 changes: 2 additions & 2 deletions resources/xlf/de/sql.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7096,11 +7096,11 @@ Fehler: {1}</target>
<trans-unit id="miGettingStarted">
<source xml:lang="en">Getting &amp;&amp;Started</source>
<note>&amp;&amp; denotes a mnemonic</note>
<target state="new">Getting &amp;&amp;Started</target>
<target state="translated">Erste &amp;&amp;Schritte</target>
</trans-unit>
<trans-unit id="showReleaseNotes">
<source xml:lang="en">Show Getting Started</source>
<target state="new">Show Getting Started</target>
<target state="translated">"Erste Schritte" anzeigen</target>
</trans-unit>
</body>
</file>
Expand Down
4 changes: 2 additions & 2 deletions resources/xlf/es/sql.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7096,11 +7096,11 @@ Error: {1}</target>
<trans-unit id="miGettingStarted">
<source xml:lang="en">Getting &amp;&amp;Started</source>
<note>&amp;&amp; denotes a mnemonic</note>
<target state="new">Getting &amp;&amp;Started</target>
<target state="translated">I&amp;&amp;ntroducción</target>
</trans-unit>
<trans-unit id="showReleaseNotes">
<source xml:lang="en">Show Getting Started</source>
<target state="new">Show Getting Started</target>
<target state="translated">Ver introducción</target>
</trans-unit>
</body>
</file>
Expand Down
4 changes: 2 additions & 2 deletions resources/xlf/fr/sql.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7096,11 +7096,11 @@ Erreur : {1}</target>
<trans-unit id="miGettingStarted">
<source xml:lang="en">Getting &amp;&amp;Started</source>
<note>&amp;&amp; denotes a mnemonic</note>
<target state="new">Getting &amp;&amp;Started</target>
<target state="translated">Pri&amp;&amp;se en main</target>
</trans-unit>
<trans-unit id="showReleaseNotes">
<source xml:lang="en">Show Getting Started</source>
<target state="new">Show Getting Started</target>
<target state="translated">Afficher la mise en route</target>
</trans-unit>
</body>
</file>
Expand Down
4 changes: 2 additions & 2 deletions resources/xlf/it/sql.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7096,11 +7096,11 @@ Errore: {1}</target>
<trans-unit id="miGettingStarted">
<source xml:lang="en">Getting &amp;&amp;Started</source>
<note>&amp;&amp; denotes a mnemonic</note>
<target state="new">Getting &amp;&amp;Started</target>
<target state="translated">&amp;&amp;Introduzione</target>
</trans-unit>
<trans-unit id="showReleaseNotes">
<source xml:lang="en">Show Getting Started</source>
<target state="new">Show Getting Started</target>
<target state="translated">Mostra introduzione</target>
</trans-unit>
</body>
</file>
Expand Down
4 changes: 2 additions & 2 deletions resources/xlf/ja/sql.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7096,11 +7096,11 @@ Error: {1}</source>
<trans-unit id="miGettingStarted">
<source xml:lang="en">Getting &amp;&amp;Started</source>
<note>&amp;&amp; denotes a mnemonic</note>
<target state="new">Getting &amp;&amp;Started</target>
<target state="translated">はじめに(&amp;&amp;S)</target>
</trans-unit>
<trans-unit id="showReleaseNotes">
<source xml:lang="en">Show Getting Started</source>
<target state="new">Show Getting Started</target>
<target state="translated">「はじめに」を表示する</target>
</trans-unit>
</body>
</file>
Expand Down
4 changes: 2 additions & 2 deletions resources/xlf/ko/sql.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7096,11 +7096,11 @@ Error: {1}</source>
<trans-unit id="miGettingStarted">
<source xml:lang="en">Getting &amp;&amp;Started</source>
<note>&amp;&amp; denotes a mnemonic</note>
<target state="new">Getting &amp;&amp;Started</target>
<target state="translated">시작(&amp;&amp;S)</target>
</trans-unit>
<trans-unit id="showReleaseNotes">
<source xml:lang="en">Show Getting Started</source>
<target state="new">Show Getting Started</target>
<target state="translated">시작 표시</target>
</trans-unit>
</body>
</file>
Expand Down
4 changes: 2 additions & 2 deletions resources/xlf/pt-br/sql.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7097,11 +7097,11 @@ Erro: {1}</target>
<trans-unit id="miGettingStarted">
<source xml:lang="en">Getting &amp;&amp;Started</source>
<note>&amp;&amp; denotes a mnemonic</note>
<target state="new">Getting &amp;&amp;Started</target>
<target state="translated">I&amp;&amp;ntrodução</target>
</trans-unit>
<trans-unit id="showReleaseNotes">
<source xml:lang="en">Show Getting Started</source>
<target state="new">Show Getting Started</target>
<target state="translated">Mostrar Introdução</target>
</trans-unit>
</body>
</file>
Expand Down
4 changes: 2 additions & 2 deletions resources/xlf/ru/sql.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7096,11 +7096,11 @@ Error: {1}</source>
<trans-unit id="miGettingStarted">
<source xml:lang="en">Getting &amp;&amp;Started</source>
<note>&amp;&amp; denotes a mnemonic</note>
<target state="new">Getting &amp;&amp;Started</target>
<target state="translated">&amp;&amp;Начало работы</target>
</trans-unit>
<trans-unit id="showReleaseNotes">
<source xml:lang="en">Show Getting Started</source>
<target state="new">Show Getting Started</target>
<target state="translated">Показать раздел "Начало работы"</target>
</trans-unit>
</body>
</file>
Expand Down
4 changes: 2 additions & 2 deletions resources/xlf/zh-hans/sql.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7096,11 +7096,11 @@ Error: {1}</source>
<trans-unit id="miGettingStarted">
<source xml:lang="en">Getting &amp;&amp;Started</source>
<note>&amp;&amp; denotes a mnemonic</note>
<target state="new">Getting &amp;&amp;Started</target>
<target state="translated">入门(&amp;&amp;S)</target>
</trans-unit>
<trans-unit id="showReleaseNotes">
<source xml:lang="en">Show Getting Started</source>
<target state="new">Show Getting Started</target>
<target state="translated">显示入门指南</target>
</trans-unit>
</body>
</file>
Expand Down
4 changes: 2 additions & 2 deletions resources/xlf/zh-hant/sql.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7096,11 +7096,11 @@ Error: {1}</source>
<trans-unit id="miGettingStarted">
<source xml:lang="en">Getting &amp;&amp;Started</source>
<note>&amp;&amp; denotes a mnemonic</note>
<target state="new">Getting &amp;&amp;Started</target>
<target state="translated">使用者入門(&amp;&amp;S)</target>
</trans-unit>
<trans-unit id="showReleaseNotes">
<source xml:lang="en">Show Getting Started</source>
<target state="new">Show Getting Started</target>
<target state="translated">顯示使用者入門</target>
</trans-unit>
</body>
</file>
Expand Down
4 changes: 2 additions & 2 deletions src/sql/base/browser/ui/dropdownList/dropdownList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export class Dropdown extends BaseDropdown {
}
}

export class DropdownList extends BaseDropdown {
export class DropdownList extends Dropdown {
protected borderWidth = 1;

private button?: Button;
Expand Down Expand Up @@ -145,7 +145,7 @@ export class DropdownList extends BaseDropdown {
/**
* Render the dropdown contents
*/
protected renderContents(container: HTMLElement): IDisposable | null {
protected override renderContents(container: HTMLElement): IDisposable | null {
let div = DOM.append(container, this._contentContainer);
div.style.width = (DOM.getTotalWidth(this.element) - this.borderWidth * 2) + 'px'; // Subtract border width
return { dispose: () => { } };
Expand Down
Loading
Loading