Fix error when opening create project from db dialog without connection #23864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjin
approved these changes
Jul 13, 2023
SakshiS-harma
approved these changes
Jul 13, 2023
Benjin
approved these changes
Jul 13, 2023
extensions/sql-database-projects/src/dialogs/createProjectFromDatabaseDialog.ts
Outdated
Show resolved
Hide resolved
…DatabaseDialog.ts Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
kisantia
added a commit
that referenced
this pull request
Jul 13, 2023
…on (#23864) * Fix error when opening create project from db dialog without connection * Update extensions/sql-database-projects/src/dialogs/createProjectFromDatabaseDialog.ts Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com> --------- Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #23861. The update project from db dialog did not have this problem because it uses
getAzdataApi()!.connection.getCurrentConnection()to get the current connection, rather than using the profile that may or may not be passed in. Since it would be a bigger change to update the create project from db dialog to do the same thing, this is a smaller fix to verify that the profile actually has connection information, and not only{ preserverFocus: false}.I tested the other entry points (right click on server or db, command palette) to the create project from db dialog to make sure they are still working as expected.