Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info box to help user navigate the wizard #23868

Conversation

smartura
Copy link
Contributor

Added info box on target selection page of wizard to inform users of the need to click "Migrate certificates" button.

image

@AkshayMata
Copy link
Contributor

Is there a way to query the target to check for migrated certs? If show, we should do check and block them on this page

@smartura
Copy link
Contributor Author

Is there a way to query the target to check for migrated certs? If show, we should do check and block them on this page

There is no way to do that at the moment.

@brian-harris
Copy link
Contributor

The infobox is showing an informational image with the message, but the message contains a warning that you need to migrate certificates or it will fail the migration. perhaps the image should also be a warning.

@smartura
Copy link
Contributor Author

The infobox is showing an informational image with the message, but the message contains a warning that you need to migrate certificates or it will fail the migration. perhaps the image should also be a warning.

No, the message does not contain a warning that you need to migrate certificates or it will fail the migration.

The message in the info box says:
You must click the 'Migrate certificates' button before proceeding to the next page of the wizard.

It's informing the user why the next button is disabled.

image
image

I think I still prefer Information.

@smartura
Copy link
Contributor Author

smartura commented Jul 14, 2023

The infobox is showing an informational image with the message, but the message contains a warning that you need to migrate certificates or it will fail the migration. perhaps the image should also be a warning.

Actually I am rethinking this, maybe I will change it to warning. I don't think it can hurt.

Copy link
Contributor Author

@smartura smartura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed PR feedback

@AkshayMata
Copy link
Contributor

Thanks for making this change! I've seen users skip over with info, so I think this way will draw more attention to user.

Approved the changes. Not a blocker for this change, more so food for thought, but should we hide the warning box once the next button has been enabled (meaning they have clicked to migrated their certs)? Leaving the warning (or even info) box could confuse some users.

Excited to see quick improvements and those TDE numbers go up!

@smartura smartura merged commit 8161ad9 into microsoft:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants