Re-enable extension unit tests on linux build #24985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisantia
requested review from
cheenamalhotra,
Charles-Gagnon and
lewis-sanchez
Pull Request Test Coverage Report for Build 6898418130
💛 - Coveralls |
|
@lewis-sanchez Do you know why they were disabled? |
Charles-Gagnon
approved these changes
Nov 17, 2023
lewis-sanchez
approved these changes
Nov 17, 2023
|
@Charles-Gagnon, I don't know why they were disabled. The date in the {{SQL CARBON EDIT}} tag says (6/26/2023), so I'm thinking that they were turned off with the VS Code merge that happened in June: #23482 |
cheenamalhotra
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension unit tests were disabled back in June for the vscode merge. I ran an adhoc build with the extension unit tests re-enabled and they all passed, so it doesn't look like any other changes need to be made before enabling them again: https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=216436&view=logs&j=4d2898ab-dfbe-557e-92e7-aaac158fdd2f&t=b2ac4860-fb3b-5a51-42a7-7423ead0721b