Update query editor colorization to match SSMS #580

corivera · 2018-01-29T23:30:30Z

Includes updated colorization for the following:

local variables (tokens prepended with "@")
global system variables (tokens prepended with "@@")
unicode string literal prefix ("N" in front of strings)
bracketed identifiers (tokens surrounded by square brackets)
builtin SQL Server functions

corivera · 2018-01-29T23:32:43Z

extensions/sql/syntaxes/SQL.plist

+			<key>match</key>
+			<string>(((?<!@)@)|(\[\s*))\b(?i)(\w+)\b</string>
+			<key>name</key>
+			<string>text</string>


Anything with a leading '@' or '[' should be plain, uncolorized text. Is there a better "category" to use here? There's no color theming for "text", so it accomplishes the same goal.

corivera · 2018-01-29T23:47:24Z

Also removed the "support.function.scalar.sql" tokens, since they were either already covered in other token matches, or were not colorized in the SSMS editor.

corivera · 2018-01-30T23:32:02Z

Added colorization for FULL OUTER JOIN. Fixes #584

kburtram · 2018-02-01T20:43:37Z

extensions/sql/syntaxes/sql.tmLanguage.json

+			"name": "text"
+		},
+		{
+			"match": "\\b(?i)(abort|abort_after_wait|absent|absolute|accent_sensitivity|acceptable_cursopt|acp|action|activation|address|admin|aes_128|aes_192|aes_256|affinity|after|aggregate|algorithm|all_constraints|all_errormsgs|all_indexes|all_levels|all_results|allow_connections|allow_dup_row|allow_encrypted_value_modifications|allow_page_locks|allow_row_locks|allow_snapshot_isolation|altercolumn|always|anonymous|ansi_defaults|ansi_null_default|ansi_null_dflt_off|ansi_null_dflt_on|ansi_nulls|ansi_padding|ansi_warnings|appdomain|append|application|apply|arithabort|arithignore|assembly|asymmetric|asynchronous_commit|at|atan2|atomic|attach|attach_force_rebuild_log|attach_rebuild_log|audit|auth_realm|authentication|auto|auto_cleanup|auto_close|auto_create_statistics|auto_shrink|auto_update_statistics|auto_update_statistics_async|automated_backup_preference |automatic|autopilot|availability|availability_mode|backup_priority|base64|basic|batches|batchsize|before|bigint|binary|binding|bit|block|blocksize|bmk|break|broker|broker_instance|bucket_count|buffer|buffercount|bulk_logged|by|call|caller|card|case|cast|catalog|catch|cert|certificate|change_retention|change_tracking|change_tracking_context|changes|char|character|character_set|check_expiration|check_policy|checkconstraints|checkindex|checkpoint|cleanup_policy|clear|clear_port|close|codepage|collection|column_encryption_key|column_master_key|columnstore|columnstore_archive|colv_80_to_100|colv_100_to_80|commit_differential_base|committed|compatibility_level|compress_all_row_groups|compression|compression_delay|concat_null_yields_null|concatenate|configuration|connect|continue|continue_after_error|contract|contract_name|control|conversation|conversation_group_id|conversation_handle|copy|copy_only|count_rows|counter|create(\\s+procedure)?|credential|cross|cryptographic|cryptographic_provider|cube|cursor_close_on_commit|cursor_default|data|data_compression|data_flush_interval_seconds|data_mirroring|data_purity|data_source|database|database_name|database_snapshot|datafiletype|date_correlation_optimization|date|datefirst|dateformat|date_format|datetime|datetime2|datetimeoffset|days|db_chaining|dbid|dbidexec|dbo_only|deadlock_priority|deallocate|dec|decimal|declare(\\s+cursor)?|decrypt|decrypt_a|decryption|default_database|default_language|default_logon_domain|default_schema|definition|delay|delayed_durability|delimitedtext|density_vector|dependent|des|description|desired_state|desx|differential|digest|disable|disable_broker|disable_def_cnst_chk|disabled|disk|distributed|distribution|drop|drop_existing|dts_buffers|dump|durability|dynamic|edition|elements|else|emergency|empty|enable|enable_broker|enabled|encoding|encrypted|encrypted_value|encryption|encryption_type|end|endpoint|endpoint_url|enhancedintegrity|entry|error_broker_conversations|errorfile|estimateonly|event|exec|executable|execute|exists|expand|expiredate|expiry_date|explicit|external_access|failover|failover_mode|failure_condition_level|fast|fast_forward|fastfirstrow|federated_service_account|fetch|field_terminator|fieldterminator|file|filelistonly|filegroup|filename|filestream|filestream_log|filestream_on|filetable|file_format|filter|fips_flagger|fire_triggers|first|firstrow|float|flush_interval_seconds|fmtonly|following|force|force_failover_allow_data_loss|force_service_allow_data_loss|forced|forceplan|formatfile|format_options|format_type|formsof|forward_only|free_cursors|free_exec_context|fullscan|fulltext|fulltextall|fulltextkey|function|generated|get|geography|geometry|global|go|goto|governor|guid|hadoop|hardening|hash|hashed|header_limit|headeronly|health_check_timeout|hidden|hierarchyid|histogram|histogram_steps|hits_cursors|hits_exec_context|hours|http|identity_value|if|ifnull|ignore_constraints|ignore_dup_key|ignore_dup_row|ignore_triggers|image|immediate|implicit_transactions|include|include_null_values|inflectional|init|initiator|insensitive|insert|instead|int|integer|integrated|intermediate|interval_length_minutes|into|inuse_cursors|inuse_exec_context|io|is|isabout|iso_week|isolation|job_tracker_location|json|keep|keep_nulls|keep_replication|keepdefaults|keepfixed|keepidentity|keepnulls|kerberos|key|key_path|key_source|key_store_provider_name|keyset|kill|kilobytes_per_batch|labelonly|langid|language|last|lastrow|legacy_cardinality_estimation|length|level|lifetime|lineage_80_to_100|lineage_100_to_80|listener_ip|listener_port|load|loadhistory|lob_compaction|local|local_service_name|locate|location|lock_escalation|lock_timeout|lockres|login|login_type|loop|manual|mark_in_use_for_removal|masked|master|max_queue_readers|max_duration|max_outstanding_io_per_volume|maxdop|maxerrors|maxlength|maxtransfersize|max_plans_per_query|max_storage_size_mb|mediadescription|medianame|mediapassword|memogroup|memory_optimized|merge|message|message_forward_size|message_forwarding|microsecond|millisecond|minutes|mirror_address|misses_cursors|misses_exec_context|mixed|modify|money|move|multi_user|must_change|name|namespace|nanosecond|native|native_compilation|nchar|ncharacter|never|new_account|new_broker|newname|next|no|no_browsetable|no_checksum|no_compression|no_infomsgs|no_triggers|no_truncate|nocount|noexec|noexpand|noformat|noinit|nolock|nonatomic|nondurable|none|norecompute|norecovery|noreset|norewind|noskip|not|notification|nounload|now|nowait|ntext|ntlm|numeric|numeric_roundabort|nvarchar|object|objid|oem|offline|old_account|online|operation_mode|open|openjson|optimistic|option|orc|out|outer|output|over|override|owner|ownership|pad_index|page|page_checksum|page_verify|pagecount|paglock|param|parameter_sniffing|parameter_type_expansion|parameterization|parquet|parseonly|partial|partition|partner|password|path|pause|percentage|permission_set|persisted|period|physical_only|plan_forcing_mode|policy|pool|population|ports|preceding|precision|predicate|presume_abort|primary|primary_role|print|prior|priority |priority_level|private|procedure_name|profile|provider|query_capture_mode|query_governor_cost_limit|query_optimizer_hotfixes|query_store|queue|quoted_identifier|raiserror|range|raw|rcfile|rc2|rc4|rc4_128|rdbms|read_committed_snapshot|read|read_only|read_write|readcommitted|readcommittedlock|readonly|readpast|readuncommitted|readwrite|real|rebuild|receive|recmodel_70backcomp|recompile|reconfigure|recovery|recursive|recursive_triggers|redo_queue|reject_sample_value|reject_type|reject_value|relative|remote|remote_data_archive|remote_proc_transactions|remote_service_name|remove|removed_cursors|removed_exec_context|reorganize|repeat|repeatable|repeatableread|replica|replicated|replnick_100_to_80|replnickarray_80_to_100|replnickarray_100_to_80|required|required_cursopt|resample|reset|resource|resource_manager_location|restart|restore|restricted_user|resume|retaindays|retention|return|rewind|rewindonly|returns|robust|role|rollup|root|round_robin|route|row|rowdump|rowlock|row_terminator|rows|rows_per_batch|rowsets_only|rowterminator|rowversion|rsa_1024|rsa_2048|rsa_3072|rsa_4096|rsa_512|safe|safety|sample|save|schemabinding|scoped|scroll|scroll_locks|sddl|secexpr|secondary|secondary_only|secondary_role|secret|security|securityaudit|selective|self|send|sent|sequence|serde_method|serializable|server|service|service_broker|service_name|service_objective|session_timeout|session|sessions|seterror|setopts|sets|shard_map_manager|shard_map_name|sharded|shared_memory|show_statistics|showplan_all|showplan_text|showplan_xml|showplan_xml_with_recompile|shrinkdb|shutdown|sid|signature|simple|single_blob|single_clob|single_nclob|single_user|singleton|site|size_based_cleanup_mode|skip|smalldatetime|smallint|smallmoney|snapshot|snapshot_import|snapshotrestorephase|soap|softnuma|sort_in_tempdb|sorted_data|sorted_data_reorg|spatial|sql|sql_bigint|sql_binary|sql_bit|sql_char|sql_date|sql_decimal|sql_double|sql_float|sql_guid|sql_handle|sql_longvarbinary|sql_longvarchar|sql_numeric|sql_real|sql_smallint|sql_time|sql_timestamp|sql_tinyint|sql_tsi_day|sql_tsi_frac_second|sql_tsi_hour|sql_tsi_minute|sql_tsi_month|sql_tsi_quarter|sql_tsi_second|sql_tsi_week|sql_tsi_year|sql_type_date|sql_type_time|sql_type_timestamp|sql_varbinary|sql_varchar|sql_variant|sql_wchar|sql_wlongvarchar|ssl|ssl_port|standard|standby|start|start_date|started|stat_header|state|statement|static|statistics|statistics_incremental|statistics_norecompute|statistics_only|statman|stats_stream|status|stop|stop_on_error|stopat|stopatmark|stopbeforemark|stoplist|stopped|string_delimiter|subject|supplemental_logging|supported|suspend|symmetric|synchronous_commit|synonym|sysname|system|system_time|system_versioning|table|tableresults|tablock|tablockx|take|tape|target|target_index|target_partition|tcp|temporal_history_retention|text|textimage_on|then|thesaurus|throw|time|timeout|timestamp|tinyint|to|top|torn_page_detection|track_columns_updated|tran|transaction|transfer|triple_des|triple_des_3key|trustworthy|try|tsql|type|type_desc|type_warning|tzoffset|uid|unbounded|uncommitted|uniqueidentifier|unlimited|unload|unlock|unsafe|updlock|url|use|useplan|useroptions|use_type_default|using|utcdatetime|valid_xml|validation|value|values|varbinary|varchar|verbose|verifyonly|version|view_metadata|virtual_device|visiblity|waitfor|webmethod|weekday|weight|well_formed_xml|when|while|widechar|widechar_ansi|widenative|windows|with|within|witness|without|without_array_wrapper|workload|wsdl|xact_abort|xlock|xml|xmlschema|xquery|xsinil|zone)\\b",


do you know why we need to repeat the whole keyword list?

abist · 2018-02-01T22:18:02Z

Also fixes #557 it seems

corivera · 2018-02-01T22:18:49Z

@abist That issue will get fixed in my next commit

…b connection (microsoft#580)

corivera commented Jan 29, 2018

View reviewed changes

corivera added 10 commits January 31, 2018 15:19

Ignore editor keyword coloring if keywords are preceded by [ or @

4cdcf7a

Force editor text starting with [ or one @ to use plain text styling.

9f9d6b7

Add editor syntax check for unicode string literal prefix.

b1e21bd

Add editor syntax category for global system variables.

032593a

Add builtin sql server functions to editor colorization.

5d128bf

Remove redundant functions in sql syntax list.

0c0ec4c

Duplicate editor colorization changes to SQL plist

6eaf7ec

Add editor colorization for FULL OUTER JOIN.

625b602

Add some extra missing keywords and functions to editor colorization.

f1d54b0

Make sql function names lower case in syntax-checking regex.

10f902d

corivera force-pushed the corivera/FixEditorColors branch from 71ad10f to 10f902d Compare February 1, 2018 00:50

corivera requested review from MattIrv, kburtram and anthonydresser February 1, 2018 20:24

kburtram reviewed Feb 1, 2018

View reviewed changes

kburtram approved these changes Feb 1, 2018

View reviewed changes

corivera mentioned this pull request Feb 1, 2018

Added "full" to "join" prefix regex #597

Closed

corivera added 3 commits February 1, 2018 14:28

Change bracketed identifier colorization to include non-word characters.

e33ed8d

Remove unused SQL.plist from sql syntax folder.

a413366

Add yarn.lock files.

b0da73d

corivera merged commit fe04fd7 into master Feb 1, 2018

corivera deleted the corivera/FixEditorColors branch February 1, 2018 23:52

abist mentioned this pull request Feb 1, 2018

Keyword "FULL" not highlighted by IntelliSense #584

Closed

This was referenced Feb 1, 2018

single quote in column name breaks syntax highlight #557

Closed

Update SQL syntax plist to match SSMS query editor behavior. microsoft/vscode-mssql#1057

Merged

aleklj pushed a commit to aleklj/azuredatastudio that referenced this pull request Oct 28, 2019

Use requested database when determining if a connection is a system d…

efd38be

…b connection (microsoft#580)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update query editor colorization to match SSMS #580

Update query editor colorization to match SSMS #580

corivera commented Jan 29, 2018 •

edited

Loading

corivera Jan 29, 2018 •

edited

Loading

corivera commented Jan 29, 2018 •

edited

Loading

corivera commented Jan 30, 2018

kburtram Feb 1, 2018

abist commented Feb 1, 2018

corivera commented Feb 1, 2018

Update query editor colorization to match SSMS #580

Update query editor colorization to match SSMS #580

Conversation

corivera commented Jan 29, 2018 • edited Loading

corivera Jan 29, 2018 • edited Loading

Choose a reason for hiding this comment

corivera commented Jan 29, 2018 • edited Loading

corivera commented Jan 30, 2018

kburtram Feb 1, 2018

Choose a reason for hiding this comment

abist commented Feb 1, 2018

corivera commented Feb 1, 2018

corivera commented Jan 29, 2018 •

edited

Loading

corivera Jan 29, 2018 •

edited

Loading

corivera commented Jan 29, 2018 •

edited

Loading