Improved chart names for chart type dropdown. #7631
Conversation
…rnative names later
…highly recommended to implement
…into alex/alexbranch
| //Map used to store names and alternative names for chart types. | ||
| //This is mainly used for comparison when options are parsed into the constructor. | ||
| const altNameHash : {[oldName: string]: string} = { | ||
| ['horizontalBar']: 'Horziontal Bar', |
There was a problem hiding this comment.
Why is this an array mapped to a string? Why not a string to string?
| constructor(options: string[], selectedOption: string, contextViewProvider: IContextViewProvider, container?: HTMLElement, selectBoxOptions?: ISelectBoxOptions) { | ||
| super(options.map(option => { return { text: option }; }), 0, contextViewProvider, undefined, selectBoxOptions); | ||
| //originally {text :option }; | ||
| super(options.map(option => {return {text : SelectBox.parseName(option)}; }), 0, contextViewProvider, undefined, selectBoxOptions); |
There was a problem hiding this comment.
This creates a weird cyclic dependency. A component shouldn't know what's going into it - if there are general rules its applying it should be for everything rather than a specific usage of it.
For example, say this was a "Hot Water" component, a "Hot Water" component doesn't need to know its going to be used for "Tea" or "Coffee". It just needs to know how to behave on its own.
Essentially you should be doing this mapping right before it comes in here, rather than on the component itself.
Another thing you could do is extend this class and make a special case class for graph SelectBoxes - but even then if the only behavior that is different is the name, we should just pass that as a property.
Added to SelectBox a map of alternative names that are user friendly for charts.
Dropdown bar displays alternative names while not physically altering the chart objects themselves.
Fixes #38 (preliminary)