Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart display and query plan tabs now use 100% height #995

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

MattIrv
Copy link
Contributor

@MattIrv MattIrv commented Mar 26, 2018

Recent changes to how tabbed content is displayed meant that some old CSS was no longer needed in order to make them take up 100% of the available height.

@@ -3,10 +3,6 @@
width: 100%;
}

.headersVisible > .fullsize {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the height is platform specific and depends on if you are running a packaged build vs. the dev build. Have you tested this with the packaged build for both Windows and macOS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Height looks the same on Windows and Mac on the dev build, but I'll check Linux and the packaged builds too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. I've been checking a few configurations as well. And everything looks good. I want to check the mac packaged build and then I think that's probably enough validation to take into the release branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...looks good on mac packaged builds too. I'll merge to release and queue a stable release candidate build.

@kburtram kburtram merged commit e9299d1 into master Mar 26, 2018
@kburtram kburtram deleted the fix/tabContentHeight branch March 26, 2018 23:01
kburtram pushed a commit that referenced this pull request Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants