Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ptest retries to 1 for PR package build check. #10133

Merged
merged 8 commits into from
Aug 21, 2024

Conversation

PawelWMS
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

We have some flaky ptests in our set of packages. During daily builds we re-run them once in an attempt to separate most of such tests from constantly failing ones. This change aligns the PR check with the behaviour of the daily builds.

Does this affect the toolchain?

No.

Test Methodology
  • PR check.

@PawelWMS PawelWMS requested a review from a team as a code owner August 13, 2024 20:43
@mfrw mfrw added the fasttrack/2.0 PRs Destined for AzureLinux 2.0 label Aug 16, 2024
Copy link
Contributor

@rikenm1 rikenm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why this change has a PR check failure ?

@PawelWMS PawelWMS merged commit 6722ace into fasttrack/2.0 Aug 21, 2024
14 of 17 checks passed
@PawelWMS PawelWMS deleted the pawelwi/add_test_retry branch August 21, 2024 18:52
CBL-Mariner-Bot pushed a commit that referenced this pull request Aug 21, 2024
@CBL-Mariner-Bot
Copy link
Collaborator

CBL-Mariner-Bot pushed a commit that referenced this pull request Sep 9, 2024
PawelWMS added a commit that referenced this pull request Sep 12, 2024
…ecks (CP: #8503, #10133) - branch 3.0-dev (#10393)

Co-authored-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fasttrack/2.0 PRs Destined for AzureLinux 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants