Skip to content

[Medium] Patch kubevirt for CVE-2025-64435 #15137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 3.0-dev
Choose a base branch
from
Open

[Medium] Patch kubevirt for CVE-2025-64435 #15137

wants to merge 1 commit into from

Conversation

@v-aaditya
Copy link
Contributor

@v-aaditya v-aaditya commented Nov 20, 2025 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

Patch kubevirt for CVE-2025-64435

  • Upstream patch is backported manually.
  • Changes in 3 files (dra/dra.go, vmi/lifecycle.go and vim/volume-hotplug.go) have not been included in the patch as those files are not present in kubevirt <1.5.3>.
  • Some additional changes have been added in file (vmi/vmi.go), as additional source code exist in kubervirt <1.5.3> which also need modification.
  • Some dates in changelog of "kubevirt.spec" file have been corrected/updated as it was giving error while building the package.

Upstream Patch reference: https://github.com/kubevirt/kubevirt/commit/9a6f4a3a707992038ef705da4cb3bba8c89d36ba.patch

Change Log
  • new file: SPECS/kubevirt/CVE-2025-64435.patch
  • modified: SPECS/kubevirt/kubevirt.spec
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
image
  • Installation Check:
image image
  • Uninstallation Check:
image image

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Nov 20, 2025
@v-aaditya v-aaditya marked this pull request as ready for review November 20, 2025 11:44
@v-aaditya v-aaditya requested a review from a team as a code owner November 20, 2025 11:44
Kanishk-Bansal
Kanishk-Bansal reviewed Nov 20, 2025
View reviewed changes
SPECS/kubevirt/kubevirt.spec
- Address CVE-2023-44487

* Sun March 02 2025 Kanishk Bansal <kanbansal@microsoft.com> - 1.2.0-14
* Sun Mar 02 2025 Kanishk Bansal <kanbansal@microsoft.com> - 1.2.0-14
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@Kanishk-Bansal
Copy link
Contributor

Kanishk-Bansal commented Nov 20, 2025

Buddy Build

@Kanishk-Bansal Kanishk-Bansal requested a review from mfrw November 20, 2025 13:43
@v-aaditya
Copy link
Contributor Author

v-aaditya commented Nov 20, 2025

Buddy Build

Buddy Build has passed !

mfrw
mfrw approved these changes Nov 21, 2025
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SPECS/kubevirt/CVE-2025-64435.patch
Annotations: map[string]string{
v1.DomainAnnotation: vmi.Name,
},
+ OwnerReferences: []metav1.OwnerReference{*metav1.NewControllerRef(vmi, v1.VirtualMachineInstanceGroupVersionKind)},
Copy link
Member

@mfrw mfrw Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good w.r.t upstream

@Kanishk-Bansal Kanishk-Bansal added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kanishk-Bansal Kanishk-Bansal Kanishk-Bansal left review comments

@mfrw mfrw mfrw approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@v-aaditya @Kanishk-Bansal @mfrw