Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVE-2023-28155 by patching request module in nodejs #5562

Merged

Conversation

tobiasb-ms
Copy link
Contributor

@tobiasb-ms tobiasb-ms commented May 23, 2023

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Patch nodejs to fix CVE-2023-28155, which is a vulnerability in the request npm module, upon which reaper depends. This is somewhat complicated by the fact that request has been deprecated and is no longer taking updates. The patch is actually adapted from a pull request that was never and will never be merged.

Change Log

Patch CVE-2023-28155

Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Built locally and validated in logs and compiled files that the patch was installed.
  • Buddy Build

@microsoft-github-policy-service microsoft-github-policy-service bot added the 1.0-dev PR Destined for 1.0-dev label May 23, 2023
@tobiasb-ms tobiasb-ms force-pushed the tobiasb/CVE-2023-28155-nodejs branch from 64fbfe1 to 3e42062 Compare May 25, 2023 17:53
@tobiasb-ms tobiasb-ms force-pushed the tobiasb/CVE-2023-28155-nodejs branch from 3e42062 to 8b266a5 Compare May 25, 2023 19:34
@tobiasb-ms tobiasb-ms marked this pull request as ready for review May 25, 2023 20:03
@tobiasb-ms tobiasb-ms requested a review from a team as a code owner May 25, 2023 20:03
@tobiasb-ms tobiasb-ms merged commit 73dd464 into microsoft:1.0-dev May 25, 2023
@tobiasb-ms tobiasb-ms deleted the tobiasb/CVE-2023-28155-nodejs branch June 19, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0-dev PR Destined for 1.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants