Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

[#51] Tables getting bulkier with time #56

Merged
merged 29 commits into from
Dec 10, 2022

Conversation

Bertverbeek4PS
Copy link
Contributor

Based on issue #51 - Tables getting bulkier with time.
Added two tables to retention policy:

  • table 82563 "ADLSE Deleted Record"
  • table 82566 "ADLSE Run"

Also added field export because this is needed for the retention policy

Copy link
Contributor

@DuttaSoumya DuttaSoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bertverbeek4PS, I finally had time to catch up on my pending activities after conclusion of Directions. I have made a few comments on this PR. Please reach out directly/ via Teams in case of any concerns.

@Bertverbeek4PS
Copy link
Contributor Author

@Bertverbeek4PS, I finally had time to catch up on my pending activities after conclusion of Directions. I have made a few comments on this PR. Please reach out directly/ via Teams in case of any concerns.

I thought also that you were busy. No problem!
I have change it based on your comments! Thanks for reviewing this!! And the option of deleting records looks better.

Copy link
Contributor

@DuttaSoumya DuttaSoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making these changes. Could you please sync with the latest version on the main branch by:

git pull origin main

and resolving conflicts

@Bertverbeek4PS
Copy link
Contributor Author

Thank you for making these changes. Could you please sync with the latest version on the main branch by:

git pull origin main

and resolving conflicts

Thanks for looking! I have changed all in my last commit. Also the sync. Though that I have already done that. But it wasn't

Copy link
Contributor

@DuttaSoumya DuttaSoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see more objects added to the review- API pages are showing up as new objects.

Did running git pull origin main not resolve the issues? Also, if you commit, you will find that it conflicts with the main branch.
image

Please book me in for a short 15 minute meeting if I can probably advise you on Git.

best regards
Dutta

…c2adls into RetentionPolicy

# Conflicts:
#	README.md
#	businessCentral/app.json
@Bertverbeek4PS Bertverbeek4PS reopened this Dec 5, 2022
@Bertverbeek4PS
Copy link
Contributor Author

I see more objects added to the review- API pages are showing up as new objects.

Did running git pull origin main not resolve the issues? Also, if you commit, you will find that it conflicts with the main branch. image

Please book me in for a short 15 minute meeting if I can probably advise you on Git.

best regards Dutta

@DuttaSoumya sorry there was something strange with my branche. Localy it was mixed up with another branche. Have fixed that now.

@pri-kise
Copy link

pri-kise commented Dec 5, 2022

@Bertverbeek4PS sorry for jumping in so late, but shouln'd the Tables being add to the allowed tables on Company Initialization, too?

@Bertverbeek4PS
Copy link
Contributor Author

@Bertverbeek4PS sorry for jumping in so late, but shouln'd the Tables being add to the allowed tables on Company Initialization, too?

Never to late :). That is indeed a scenario that can happen indeed thanks! @DuttaSoumya agree?

Copy link
Contributor

@DuttaSoumya DuttaSoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few easy to fix comments.

@Bertverbeek4PS
Copy link
Contributor Author

@Bertverbeek4PS sorry for jumping in so late, but shouln'd the Tables being add to the allowed tables on Company Initialization, too?

Never to late :). That is indeed a scenario that can happen indeed thanks! @DuttaSoumya agree?

I have added this to codeunit 82569 "ADLSE Execution"
Not sure if that is the right place or maybe codeunit 82567 ADLSE

Copy link
Contributor

@DuttaSoumya DuttaSoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment made. Meanwhile app.json has a new version number.

@DuttaSoumya DuttaSoumya merged commit c03e3b0 into microsoft:main Dec 10, 2022
@Bertverbeek4PS Bertverbeek4PS deleted the RetentionPolicy branch August 9, 2023 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants