-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
and removed functions enabled and disable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bertverbeek4PS, I finally had time to catch up on my pending activities after conclusion of Directions. I have made a few comments on this PR. Please reach out directly/ via Teams in case of any concerns.
I thought also that you were busy. No problem! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making these changes. Could you please sync with the latest version on the main branch by:
git pull origin main
and resolving conflicts
Thanks for looking! I have changed all in my last commit. Also the sync. Though that I have already done that. But it wasn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see more objects added to the review- API pages are showing up as new objects.
Did running git pull origin main not resolve the issues? Also, if you commit, you will find that it conflicts with the main branch.
Please book me in for a short 15 minute meeting if I can probably advise you on Git.
best regards
Dutta
8a8ea7c
to
9ae707d
Compare
…c2adls into RetentionPolicy # Conflicts: # README.md # businessCentral/app.json
@DuttaSoumya sorry there was something strange with my branche. Localy it was mixed up with another branche. Have fixed that now. |
@Bertverbeek4PS sorry for jumping in so late, but shouln'd the Tables being add to the allowed tables on Company Initialization, too? |
Never to late :). That is indeed a scenario that can happen indeed thanks! @DuttaSoumya agree? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few easy to fix comments.
I have added this to codeunit 82569 "ADLSE Execution" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment made. Meanwhile app.json has a new version number.
Based on issue #51 - Tables getting bulkier with time.
Added two tables to retention policy:
Also added field export because this is needed for the retention policy