Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message that change file has been committed #2

Closed
ecraig12345 opened this issue Jul 2, 2019 · 3 comments
Closed

Add message that change file has been committed #2

ecraig12345 opened this issue Jul 2, 2019 · 3 comments

Comments

@ecraig12345
Copy link
Member

Right now there's not an obvious indication that beachball has just committed the changefile it created. It would be helpful to add a message, something like this (showing the full output as an example):

Please describe the changes for: office-ui-fabric-react
✔ Describe changes (type or choose one) › SearchBox: allow passing in id for input
✔ Change type › Patch - bug fixes; no backwards incompatible changes.

Created and committed /path/to/change/file!
Be sure to push this commit to your remote branch.

@acoates-ms
Copy link
Collaborator

Is the beachball gif part of the suggested output?

@ecraig12345
Copy link
Member Author

That would be funny, but no. :)

kenotron added a commit that referenced this issue Jul 26, 2019
@kenotron
Copy link
Member

I added this by listing all the files committed - didn't say anything about pushing tho because that might not be what users would need to do immediately next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants