Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all packages bumped get a new entry in the changelog.json… #797

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LarryKiniu
Copy link

@LarryKiniu LarryKiniu commented Nov 7, 2022

This PR fixes an issue in beachball where, If package foo depends on package bar with an entry in it's package.json:
"bar":"*"
If you update bar. both packages get bumped but only bar is getting a new entry in it's changelog.json file.

Each package, should get a new entry in it's changelog.json file.
Tested with beacball@2.31.4 on this Repo

@LarryKiniu LarryKiniu requested a review from kenotron November 7, 2022 15:03
@evancharlton
Copy link
Contributor

This feels like something that should be covered by unit tests, as this could be easily overlooked.

@LarryKiniu LarryKiniu changed the title ensure that all packages bumped get a new entry in the changelog.json… Ensure that all packages bumped get a new entry in the changelog.json… Nov 7, 2022
@LarryKiniu
Copy link
Author

This feels like something that should be covered by unit tests, as this could be easily overlooked.

I can work on adding some unit tests for this scenario.

@ecraig12345
Copy link
Member

@LarryKiniu You need to run yarn build then yarn change to generate change files.

@Netail
Copy link

Netail commented Jun 16, 2024

Seems to also add "bumped package to vX.X.X" of packages which didn't got bumped.

E.g if you have 4 packages;

{
    "name": "foo",
    "version": "0.1.0",
    "dependencies": {
        "bar": "*",
        "baz": "*"
    }
}
{
    "name": "bar",
    "version": "0.1.0",
}
{
    "name": "baz",
    "version": "0.1.0",
}
{
    "name": "faa",
    "version": "0.1.0",
    "dependencies": {
        "baz": "*"
    }
}

If you have a changefile for Bar, it will bump Foo, Bar & Faa. Faa is also included in the bump list as it has a dependency with the * wildcard. It does not filter on only related dependents.

Foo's changelog will include; "bump bar to X" & "bump baz to X" (Shouldn't include baz as it didn't have a changefile), but also Faa's changelog will be bumped with the baz package, while it wasn't included in the changefile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants