Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default --yes to true in CI #835

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Default --yes to true in CI #835

merged 1 commit into from
Mar 9, 2023

Conversation

ecraig12345
Copy link
Member

@ecraig12345 ecraig12345 commented Mar 9, 2023

The point of automated publishing is that it's...automated, so it's a bit silly to require people to manually pass -y or --yes when publishing in a CI context (and the failure mode tends to be bad/non-obvious as described in #812).

This PR changes the default of the yes option to true if CI (most platforms) or TF_BUILD (ADO) is set. Checks for other platforms' variables could be added if needed, but I looked at the docs for some other major platforms and all the ones I found set CI.

This could potentially be considered a breaking change, but yes is only used during publishing, and I'm not sure how anyone could be doing automated publishing without this option already set, so it's probably okay. (Also easily mitigated by setting to false manually.)

Fixes #812

@ecraig12345 ecraig12345 requested a review from kenotron March 9, 2023 03:04
@kenotron kenotron merged commit 4cd3fe3 into master Mar 9, 2023
@kenotron kenotron deleted the ecraig/ci branch March 9, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish task is successful in CI, but no packages were published
2 participants