Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

spk reconcile should remove rings from hld once they've been remove from a project #1118

@mtarng

Description

@mtarng

As a:
spk user
I want:
my hld repository to be reconciled once i remove a ring from my project

Describe the solution you'd like:
when i remove a ring via spk ring delete, I expect the project lifecycle pipeline to:

  • For each linked service in this project's bedrock.yaml, in the HLD repository:
    • Remove the ring from the service's component.yaml
    • Remove the ring directory from the service's directory.

Acceptance Criteria:

  • As a user, if I remove a ring, then the changes are reflected in: the associated bedrock.yaml, my hld repository, and the materialized repository.
    • for every service in my application reppository, every service to have the removed ring… removed
    • p-1: delete just the ring directory for every service
    • p-unicorn: delete the configuration for the ring at every level it is referenced in the HLD
    • idea: copy all config content into memory, mapped by path, blow away existing HLD, re-generate new HLD based on bedrock.yaml, emit config content in memory to config files at path.
      • ¡idempotent!

Integration test should be handled by:
#974 and #1205

Additional context:
ring management epic: #955

Does this require updates to documentation?:
yes!

Metadata

Metadata

Assignees

Labels

effort - Mless than one week effortenhancementNew feature or requestx-projectMapped to external projects

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions