Updated BA2004 for HashType.None #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- work around certain files being listed as HashType.None by MSVC - pch files - the TU used to create a pch in objs using said pch - certain compiler inserted code - Check MASM files for Hash types as all MASM compilers support SHA_256 hash checksums - ml and ml64 /ZH:SHA_256 - armasm and armasm64 /gh:SHA_256 Supporting changes: - Added `CompilerCommandLine.GetOptionValue` to get commandline parameter options as strings - Added support for the MASM assembler family for - CompilerNames - WellKnownCompilers Incidental fixes: - Fixed issue in BA2007 where it skipped processing C++ warning levels.
| @@ -100,7 +100,8 @@ public override void AnalyzePortableExecutableAndPdb(BinaryAnalyzerContext conte | |||
| ObjectModuleDetails omDetails = om.GetObjectModuleDetails(); | |||
|
|
|||
| // Detection applies to C/C++ produced by MS compiler only | |||
| if (omDetails.WellKnownCompiler != WellKnownCompilers.MicrosoftC) | |||
| if (omDetails.WellKnownCompiler != WellKnownCompilers.MicrosoftC && | |||
| omDetails.WellKnownCompiler != WellKnownCompilers.MicrosoftCxx) | |||
There was a problem hiding this comment.
nooooooooo.
thanks for this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting changes:
CompilerCommandLine.GetOptionValueto get commandline parameter options as stringsIncidental fixes: