BA2026.EnableAdditionalSecurityChecks #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddynaka
reviewed
Jun 21, 2021
src/BinSkim.Rules/RuleResources.resx
Outdated
| <data name="BA2026_EnableAdditionalSecurityChecks_Description" xml:space="preserve"> | ||
| <value>/sdl enables a superset of the baseline security checks provided by /GS and overrides /GS-. By default, /sdl is off. /sdl- disables the additional security checks.</value> | ||
| </data> | ||
| <data name="BA2026_Error" xml:space="preserve"> |
There was a problem hiding this comment.
sounds good, fixed
eddynaka
reviewed
Jun 21, 2021
src/BinSkim.Rules/RuleResources.resx
Outdated
| <value>/sdl enables a superset of the baseline security checks provided by /GS and overrides /GS-. By default, /sdl is off. /sdl- disables the additional security checks.</value> | ||
| </data> | ||
| <data name="BA2026_Error" xml:space="preserve"> | ||
| <value>'{0}' does not enable the recommended Security Development Lifecycle (SDL) checks. To Enable the recommended Security Development Lifecycle (SDL) checks pass /sdl</value> |
There was a problem hiding this comment.
fixed, copied from existing ones:
"pass ..... on the cl.exe command-line"
eddynaka
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.