Fix read data out of boundary cause System.AccessViolationException #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddynaka
reviewed
Aug 27, 2021
| @@ -249,6 +249,11 @@ public byte[] ReadBlock(uint size) | |||
| /// <param name="position">The position.</param> | |||
| public byte[] ReadBlock(uint size, int position) | |||
| { | |||
| if (position >= Data.Length) | |||
There was a problem hiding this comment.
pls, add an entry in the releasehistory about this change #Resolved
eddynaka
reviewed
Aug 27, 2021
| @@ -249,6 +249,11 @@ public byte[] ReadBlock(uint size) | |||
| /// <param name="position">The position.</param> | |||
| public byte[] ReadBlock(uint size, int position) | |||
| { | |||
| if (position >= Data.Length) | |||
There was a problem hiding this comment.
yes! have no idea currently but let me check
There was a problem hiding this comment.
not able to get the exact same issue but I found another issue which is similar out of boundary. it is when compiled with special machine type.
fixed the error and added 2 test files.
eddynaka
approved these changes
Aug 31, 2021
eddynaka
reviewed
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.