Send assembly references to Telemetry #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongyan-gh
requested review from
eddynaka and
michaelcfanning
as code owners
eddynaka
reviewed
Sep 29, 2021
| private const string SummaryEventName = "AnalysisSummary"; | ||
|
|
||
| private readonly int ChunkSize = 8192; |
eddynaka
reviewed
Sep 29, 2021
| private const string CompilerEventName = "CompilerInformation"; | ||
| private const string CommandLineEventName = "CommandLineInformation"; | ||
| private const string AssemblyReferencesEventName = "AssemblyReferencesInformation"; | ||
| private const string SummaryEventName = "AnalysisSummary"; |
eddynaka
reviewed
Sep 29, 2021
| { | ||
| Initialize(appInsightsKey); | ||
| this.appInsightsRegistered = true; | ||
|
|
There was a problem hiding this comment.
can u remove this new line? #Closed
shaopeng-gh
reviewed
Sep 29, 2021
| s_sessionId = TelemetryEnabled ? Guid.NewGuid().ToString() : null; | ||
| ChunkSize = chunkSize; | ||
|
|
||
| if (!TelemetryEnabled) |
There was a problem hiding this comment.
the code in below block is to initialize a TelemetryClient instance to be used to send telemetry data.
if caller already passed in the TelemetryClient instance in constructor, we don't need to initialize a new instance.
Added the TelemetryClient / Configuration as constructor parameter so that we can overwrite the built-in instances. The unit tests can pass in mock client/configuration for testing purpose.
There was a problem hiding this comment.
also, since we are creating the compilerdatalogger for each object, we dont need to keep creating an instance of the telemetry.
with that, once it is initialized, it won't create again
eddynaka
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read assembly references from managed assemblies and send to telemetry by chunks.