Enabling multithread analysis #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaopeng-gh
reviewed
Oct 8, 2021
| @@ -153,7 +153,7 @@ private AnalysisSummary ExtractAnalysisSummary(SarifLog sarifLog, AnalyzeOptions | |||
| NormalizedPath = string.Join(";", options.TargetFileSpecifiers.Select(p => System.IO.Path.GetDirectoryName(p)).Distinct()), | |||
| SymbolPath = options.SymbolsPath, | |||
| FileAnalyzed = artifacts.Count, | |||
| // FileNotAnalyzed = | |||
| // FileNotAnalyzed = | |||
shaopeng-gh
reviewed
Oct 8, 2021
| PropertiesDictionary configData = policy.GetProperty(MitigatedCompilers); | ||
| foreach (string key in configData.Keys) | ||
| { | ||
| var machine = (MachineFamily)Enum.Parse(typeof(MachineFamily), key); // Neaten this up. | ||
| compilerData.Add(machine, CreateSortedVersionDictionary((PropertiesDictionary)configData[key])); | ||
| compilerData.TryAdd(machine, CreateSortedVersionDictionary((PropertiesDictionary)configData[key])); |
There was a problem hiding this comment.
dont think so.
Once the first thread or first analysis pass in the compilerData, the object would not be null and that path wouldn't pass anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change I'm enabling multithreading analysis, updating sarif-sdk submodules to the latest version, which contains the relevant changes to enable multithreading + hashing.
The multithreading starts reading files as an IEnumerable and adds those files to the processing channels.
If hashing is enabled, it would prevent doing the same analysis twice.