Add osx-x64 release #576

marmegh · 2022-02-16T22:23:40Z

Addressing issue #554
@jeffersonking, recommended adding osx-x64 specific release binaries per the dotnet documentation on runtime identifier (RID).

@eddynaka and @michaelcfanning, still need to get the result tested on mac to see if this resolves the issue. Will update accordingly and publish for formal review once this step is complete. Feel free to add any feedback before this.

Results of test run (verify code signing and codesign validation steps, disabled publish steps):

eddynaka · 2022-04-15T18:03:47Z

@marmegh ,

The change looks ok but we should test it.
My suggestion is: update the yaml pipeline to test on a mac. using the command line, you would be able to verify how to run it and analyze binskim itself.

michaelcfanning · 2022-04-25T19:30:00Z

@eddynaka, can you help make your proposed pipeline change, it's an excellent suggestion.

In reply to: 1108956840

eddynaka · 2022-04-29T21:27:55Z

Sorry for the delay.
I was able to produce a few changes in some files to test during the build pipeline.

In reply to: 1108956840

eddynaka · 2022-04-29T21:28:54Z

ado-build.yml

@@ -32,3 +27,23 @@ jobs:
      script: 'BuildAndTest.cmd'

  - task: ComponentGovernanceComponentDetection@0
+    inputs:
+      ignoreDirectories: '..\src\sarif-sdk'


we already have component governance in sarif-sdk. We don't need to analyze here as well.

So, let's ignore the entire submodule. #Closed

eddynaka · 2022-04-29T21:29:36Z

ado-build.yml

+    displayName: 'Run BinSkim'
+    inputs:
+      targetType: 'inline'
+      script: 'dotnet bld/bin/x64_Release/netcoreapp3.1/binskim.dll analyze src/Test.FunctionalTests.BinSkim.Driver/BaselineTestData/macho.*'


dotnet bld/bin/x64_Release/netcoreapp3.1/binskim.dll

we should add this in some doc.
the user would need to execute:
dotnet binskim.dll analyze .... #Resolved

+1

I see one candidate place,
at the bottom of the readme.md
we currently have:

Example: binskim.exe analyze c:\bld\*.dll --recurse --output MyRun.sarif

I think we can change it to 3 OS version example here.

we can also consider if want to include the path in the example to make it more clear, because the previous step is unzip.

more info fyi
I found that we have this file "BinSkim" in the package
./BinSkim analyze
I just tried works in Linux.

@shaopeng-gh, could you clarify where you found this file?

download package from
https://www.nuget.org/packages/Microsoft.CodeAnalysis.BinSkim/
(which is the result of our build and package)
unzip
go to folder \tools\netcoreapp3.1\linux-x64
file "BinSkim" without ext

Apologies. I was confused since this change is specific to osx. You were being helpful, I was concerned you were telling me we had a binary for linux in the wrong location.

macOS also have a same file in same location, after your change:
\tools\netcoreapp3.1\osx-x64\BinSkim

I point out in the case we want to add doc for user
see if we want to say use
./BinSkim analyze
or
dotnet binskim.dll analyze

When I created this, I didn't want to change the current directory that we are right now. So, it is why we have the full path.

But, in the end, it is the same as dotnet binskim.dll analyze.

Mary also updated the readme showing where the files will be. so, I think, Shaopeng's suggestion is to add the dotnet binskim.dll analyze as a new step in the readme

I think, Shaopeng's suggestion is to add the dotnet binskim.dll analyze as a new step in the readme
------ yes, I think it is not necessary, it should be clear enough, just throwing ideals, let me close this comment.

eddynaka · 2022-04-29T21:30:38Z

src/Test.FunctionalTests.BinSkim.Driver/AnalyzeCommandTests.cs

@@ -65,7 +65,11 @@ public void AnalyzeCommand_ReadSarifLog_ShouldBeAbleToReadCurrent()
        [Obsolete]
        public void AnalyzeCommand_Hashes_ShouldUpdateDataToInsert()


AnalyzeCommand_Hashes_ShouldUpdateDataToInsert

This test were failing in the unix pipelines. With the changes below, i was able to make it pass. #Closed

eddynaka · 2022-04-29T21:31:36Z

FYI, the windows pipeline isn't working properly.
I opened an issue in the ComponentGovernance team since its throwing an exception.

In reply to: 1113754507

eddynaka · 2022-04-29T21:41:18Z

For the point above, i was able to fix it already. :)

In reply to: 1113758229

eddynaka · 2022-05-10T22:56:47Z

README.md

@@ -22,9 +22,9 @@ This repository contains the source code for BinSkim, a Portable Executable (PE)
 ### How to extract the exe file from the nuget package
 If you only want to run the Binskim tool without installing anything, then you can 
 1. Download BinSkim from **[NuGet](https://www.nuget.org/packages/Microsoft.CodeAnalysis.BinSkim/)**
-2. Rename the file extension from .nupkg to .zip
+2. Rename the file extension from .nupkg to .zip (ie. via commandline: `rename microsoft.codeanalysis.binskim.x.y.z.nupkg microsoft.codeanalysis.binskim.1.9.4.zip`)


1.9.4

update this to x.y.z #Resolved

eddynaka · 2022-05-10T22:58:19Z

src/ReleaseHistory.md

@@ -5,6 +5,7 @@
 * Bump ELFSharp from 2.13.2 to 2.14.0. [#628](https://github.com/microsoft/binskim/pull/628)
 * Bump System.Reflection.Metadata from 5.0.0 to 6.0.1 and System.Collections.Immutable from 5.0.0 to 6.0.0. [#605](https://github.com/microsoft/binskim/pull/605)
 * Bump ELFSharp from 2.14.0 to 2.15.0. [#631](https://github.com/microsoft/binskim/pull/631)
+* BUGFIX: Unblock running binskim on MacOS. [#576](https://github.com/microsoft/binskim/pull/576)


BUGFIX

not sure if this is considerable a bugfix.
maybe feature: enable BinSkim for MacOS. or something like that. #Resolved

eddynaka

shaopeng-gh · 2022-05-19T20:39:41Z

src/ReleaseHistory.md

@@ -5,6 +5,7 @@
 * Bump ELFSharp from 2.13.2 to 2.14.0. [#628](https://github.com/microsoft/binskim/pull/628)
 * Bump System.Reflection.Metadata from 5.0.0 to 6.0.1 and System.Collections.Immutable from 5.0.0 to 6.0.0. [#605](https://github.com/microsoft/binskim/pull/605)
 * Bump ELFSharp from 2.14.0 to 2.15.0. [#631](https://github.com/microsoft/binskim/pull/631)
+* FEATURE: Enable BinSkim for MacOS. [#576](https://github.com/microsoft/binskim/pull/576)
 - Bump Sarif.Sdk by updating submodule from [4e9f606 to fc9a9df](https://github.com/microsoft/sarif-sdk/compare/4e9f606bb0e88428866e253352cdc70dc68f98cb...fc9a9dfb865096b5aaa9fa3651854670940f7459). [#638](https://github.com/microsoft/binskim/pull/638)


looks like a typo should be * ? #Resolved

shaopeng-gh · 2022-05-19T20:46:26Z

BuildAndTest.sh

@@ -1,11 +1,12 @@
 #!/bin/bash


there is also a file "UpdateBaselines.sh" which was for Linux only, not sure if we want to update that. #ByDesign

What would be the proposed change? I don't see any reference in that file to BinSkimLinux.sln or the uname variable.

oh because I see this file is running under folder /netcoreapp3.1/linux-x64/
I don't think we need another one running for macOS.

shaopeng-gh

marmegh added 2 commits February 16, 2022 14:17

Add osx-x64 release binaries.

f33f95a

update release history

ef001c6

eddynaka added 11 commits April 25, 2022 15:56

Adding macos to build pipeline

fc8294d

Merge branch 'main' into users/marmegh/addMacRelease

2a46516

Updating script

14b6371

Testing uname

717b750

Updating BuildAndTest

886e808

Fixing pipeline issues.

757c10e

Updating tests and script

82776db

Updating script - 2

52c6f94

Updating ado-build and ignore sarif-sdk

d5e18d0

Testing simplication in execution

91ae6d8

Reverting change

4fe1b30

trying to ignore path

26f9982

eddynaka reviewed Apr 29, 2022

View reviewed changes

marmegh added 4 commits April 29, 2022 14:49

Updating readme install directions.

6091ed1

Addressed feedback on README

3002a22

Update sarif sdk to match main.

d2440db

Reverting any sarif sdk changes.

e43f651

marmegh marked this pull request as ready for review May 10, 2022 17:52

marmegh requested a review from michaelcfanning as a code owner May 10, 2022 17:52

Merge branch 'main' into users/marmegh/addMacRelease

e471ba6

eddynaka reviewed May 10, 2022

View reviewed changes

Addressed PR feedback.

20af336

eddynaka approved these changes May 10, 2022

View reviewed changes

Merge branch 'main' into users/marmegh/addMacRelease

df30937

shaopeng-gh reviewed May 19, 2022

View reviewed changes

shaopeng-gh approved these changes May 19, 2022

View reviewed changes

marmegh added 2 commits May 19, 2022 15:06

Fix typo in release history

e1dfce3

Added analyze invocation to ReadMe instructions

e29ce83

marmegh enabled auto-merge (squash) May 19, 2022 23:26

marmegh merged commit d107b63 into main May 19, 2022

marmegh deleted the users/marmegh/addMacRelease branch May 19, 2022 23:37

marmegh mentioned this pull request Jun 21, 2022

Releasing v1.9.5 #655

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add osx-x64 release #576

Add osx-x64 release #576

marmegh commented Feb 16, 2022 •

edited

Loading

eddynaka commented Apr 15, 2022

michaelcfanning commented Apr 25, 2022 •

edited by marmegh

Loading

eddynaka commented Apr 29, 2022

eddynaka Apr 29, 2022 •

edited by marmegh

Loading

eddynaka Apr 29, 2022 •

edited by shaopeng-gh

Loading

shaopeng-gh May 19, 2022

shaopeng-gh May 19, 2022

marmegh May 19, 2022

shaopeng-gh May 19, 2022

marmegh May 19, 2022

shaopeng-gh May 19, 2022

eddynaka May 19, 2022

eddynaka May 19, 2022

shaopeng-gh May 19, 2022

eddynaka Apr 29, 2022 •

edited by marmegh

Loading

eddynaka commented Apr 29, 2022

eddynaka commented Apr 29, 2022

eddynaka May 10, 2022 •

edited by marmegh

Loading

eddynaka May 10, 2022 •

edited by marmegh

Loading

eddynaka left a comment

shaopeng-gh May 19, 2022 •

edited by marmegh

Loading

shaopeng-gh May 19, 2022 •

edited

Loading

marmegh May 19, 2022

shaopeng-gh May 19, 2022

shaopeng-gh left a comment

		@@ -65,7 +65,11 @@ public void AnalyzeCommand_ReadSarifLog_ShouldBeAbleToReadCurrent()
		[Obsolete]
		public void AnalyzeCommand_Hashes_ShouldUpdateDataToInsert()

Add osx-x64 release #576

Add osx-x64 release #576

Conversation

marmegh commented Feb 16, 2022 • edited Loading

eddynaka commented Apr 15, 2022

michaelcfanning commented Apr 25, 2022 • edited by marmegh Loading

eddynaka commented Apr 29, 2022

eddynaka Apr 29, 2022 • edited by marmegh Loading

Choose a reason for hiding this comment

eddynaka Apr 29, 2022 • edited by shaopeng-gh Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eddynaka Apr 29, 2022 • edited by marmegh Loading

Choose a reason for hiding this comment

eddynaka commented Apr 29, 2022

eddynaka commented Apr 29, 2022

eddynaka May 10, 2022 • edited by marmegh Loading

Choose a reason for hiding this comment

eddynaka May 10, 2022 • edited by marmegh Loading

Choose a reason for hiding this comment

eddynaka left a comment

Choose a reason for hiding this comment

shaopeng-gh May 19, 2022 • edited by marmegh Loading

Choose a reason for hiding this comment

shaopeng-gh May 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shaopeng-gh left a comment

Choose a reason for hiding this comment

marmegh commented Feb 16, 2022 •

edited

Loading

michaelcfanning commented Apr 25, 2022 •

edited by marmegh

Loading

eddynaka Apr 29, 2022 •

edited by marmegh

Loading

eddynaka Apr 29, 2022 •

edited by shaopeng-gh

Loading

eddynaka Apr 29, 2022 •

edited by marmegh

Loading

eddynaka May 10, 2022 •

edited by marmegh

Loading

eddynaka May 10, 2022 •

edited by marmegh

Loading

shaopeng-gh May 19, 2022 •

edited by marmegh

Loading

shaopeng-gh May 19, 2022 •

edited

Loading