Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] collect image for other images #1166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lalo
Copy link
Member

@lalo lalo commented Aug 30, 2022

solves #1164

@lalo
Copy link
Member Author

lalo commented Aug 30, 2022

@chwarr not sure which python format tool you used before, tried black but it's messing too many things. BTW, haven't executed this code

@chwarr
Copy link
Member

chwarr commented Aug 30, 2022

I don't think I used a Python formatting tool. I used pylint for linting and Mypy for static typing. I probably used Emacs' python-mode for formatting. The indentation style where arguments are indented to the opening parenthesis looks like what python-mode would do:

    parser.add_argument('root_filters',
                        nargs='+',
                        type=semi_list,
                        help="""semi-colon seperated list of arguments for one invocation of `git
                        rev-parse`. The commits in the union of these
                        rev-parse invocations are used to find container images
                        that are referenced by source code. Ex:
                        '--remotes=origin;--since=2~weeks~ago' or '--tags;-n;1'""")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants