Skip to content

Commit

Permalink
Disable failing JwtTokenValidationTests (#5833) (#5834)
Browse files Browse the repository at this point in the history 
Co-authored-by: Eric Dahlvang <erdahlva@microsoft.com>
  • Loading branch information
@mrivera-ms @EricDahlvang
mrivera-ms and EricDahlvang authored Aug 12, 2021
1 parent 82b7d37 commit 50ddade
Showing 1 changed file with 80 additions and 72 deletions.
152 changes: 80 additions & 72 deletions tests/Microsoft.Bot.Connector.Tests/Authentication/JwtTokenValidationTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,36 +30,39 @@ public JwtTokenValidationTests()
emptyClient = new HttpClient();
}

[Fact]
public async void Connector_AuthHeader_CorrectAppIdAndServiceUrl_ShouldValidate()
{
string header = $"Bearer {await new MicrosoftAppCredentials("2cd87869-38a0-4182-9251-d056e8f0ac24", "2.30Vs3VQLKt974F").GetTokenAsync()}";
var credentials = new SimpleCredentialProvider("2cd87869-38a0-4182-9251-d056e8f0ac24", string.Empty);
var result = await JwtTokenValidation.ValidateAuthHeader(header, credentials, new SimpleChannelProvider(), string.Empty, "https://webchat.botframework.com/", client);

Assert.True(result.IsAuthenticated);
}

[Fact]
public async void Connector_AuthHeader_BotAppIdDiffers_ShouldNotValidate()
{
string header = $"Bearer {await new MicrosoftAppCredentials("2cd87869-38a0-4182-9251-d056e8f0ac24", "2.30Vs3VQLKt974F").GetTokenAsync()}";
var credentials = new SimpleCredentialProvider("00000000-0000-0000-0000-000000000000", string.Empty);

await Assert.ThrowsAsync<UnauthorizedAccessException>(
async () => await JwtTokenValidation.ValidateAuthHeader(header, credentials, new SimpleChannelProvider(), string.Empty, null, client));
}

[Fact]
public async void Connector_AuthHeader_BotWithNoCredentials_ShouldNotValidate()
{
// token received and auth disabled
string header = $"Bearer {await new MicrosoftAppCredentials("2cd87869-38a0-4182-9251-d056e8f0ac24", "2.30Vs3VQLKt974F").GetTokenAsync()}";
var credentials = new SimpleCredentialProvider(string.Empty, string.Empty);

await Assert.ThrowsAsync<UnauthorizedAccessException>(
async () => await JwtTokenValidation.ValidateAuthHeader(header, credentials, new SimpleChannelProvider(), string.Empty, null, client));
}
// Disabled after appid was deleted. Issue created to move tests to functional tests
//[Fact]
//public async void Connector_AuthHeader_CorrectAppIdAndServiceUrl_ShouldValidate()
//{
// string header = $"Bearer {await new MicrosoftAppCredentials("2cd87869-38a0-4182-9251-d056e8f0ac24", "2.30Vs3VQLKt974F").GetTokenAsync()}";
// var credentials = new SimpleCredentialProvider("2cd87869-38a0-4182-9251-d056e8f0ac24", string.Empty);
// var result = await JwtTokenValidation.ValidateAuthHeader(header, credentials, new SimpleChannelProvider(), string.Empty, "https://webchat.botframework.com/", client);

// Assert.True(result.IsAuthenticated);
//}

// Disabled after appid was deleted. Issue created to move tests to functional tests
//[Fact]
//public async void Connector_AuthHeader_BotAppIdDiffers_ShouldNotValidate()
//{
// string header = $"Bearer {await new MicrosoftAppCredentials("2cd87869-38a0-4182-9251-d056e8f0ac24", "2.30Vs3VQLKt974F").GetTokenAsync()}";
// var credentials = new SimpleCredentialProvider("00000000-0000-0000-0000-000000000000", string.Empty);

// await Assert.ThrowsAsync<UnauthorizedAccessException>(
// async () => await JwtTokenValidation.ValidateAuthHeader(header, credentials, new SimpleChannelProvider(), string.Empty, null, client));
//}

// Disabled after appid was deleted. Issue created to move tests to functional tests
//[Fact]
//public async void Connector_AuthHeader_BotWithNoCredentials_ShouldNotValidate()
//{
// // token received and auth disabled
// string header = $"Bearer {await new MicrosoftAppCredentials("2cd87869-38a0-4182-9251-d056e8f0ac24", "2.30Vs3VQLKt974F").GetTokenAsync()}";
// var credentials = new SimpleCredentialProvider(string.Empty, string.Empty);

// await Assert.ThrowsAsync<UnauthorizedAccessException>(
// async () => await JwtTokenValidation.ValidateAuthHeader(header, credentials, new SimpleChannelProvider(), string.Empty, null, client));
//}

[Fact]
public async void EmptyHeader_BotWithNoCredentials_ShouldThrow()
Expand All @@ -71,24 +74,26 @@ await Assert.ThrowsAsync<ArgumentNullException>(
async () => await JwtTokenValidation.ValidateAuthHeader(header, credentials, new SimpleChannelProvider(), string.Empty, null, emptyClient));
}

[Fact]
public async void Emulator_MsaHeader_CorrectAppIdAndServiceUrl_ShouldValidate()
{
string header = $"Bearer {await new MicrosoftAppCredentials("2cd87869-38a0-4182-9251-d056e8f0ac24", "2.30Vs3VQLKt974F").GetTokenAsync()}";
var credentials = new SimpleCredentialProvider("2cd87869-38a0-4182-9251-d056e8f0ac24", string.Empty);
var result = await JwtTokenValidation.ValidateAuthHeader(header, credentials, new SimpleChannelProvider(), string.Empty, "https://webchat.botframework.com/", emptyClient);
// Disabled after appid was deleted. Issue created to move tests to functional tests
//[Fact]
//public async void Emulator_MsaHeader_CorrectAppIdAndServiceUrl_ShouldValidate()
//{
// string header = $"Bearer {await new MicrosoftAppCredentials("2cd87869-38a0-4182-9251-d056e8f0ac24", "2.30Vs3VQLKt974F").GetTokenAsync()}";
// var credentials = new SimpleCredentialProvider("2cd87869-38a0-4182-9251-d056e8f0ac24", string.Empty);
// var result = await JwtTokenValidation.ValidateAuthHeader(header, credentials, new SimpleChannelProvider(), string.Empty, "https://webchat.botframework.com/", emptyClient);

Assert.True(result.IsAuthenticated);
}
// Assert.True(result.IsAuthenticated);
//}

[Fact]
public async void Emulator_MsaHeader_BotAppIdDiffers_ShouldNotValidate()
{
string header = $"Bearer {await new MicrosoftAppCredentials("2cd87869-38a0-4182-9251-d056e8f0ac24", "2.30Vs3VQLKt974F").GetTokenAsync()}";
var credentials = new SimpleCredentialProvider("00000000-0000-0000-0000-000000000000", string.Empty);
await Assert.ThrowsAsync<UnauthorizedAccessException>(
async () => await JwtTokenValidation.ValidateAuthHeader(header, credentials, new SimpleChannelProvider(), string.Empty, null, emptyClient));
}
// Disabled after appid was deleted. Issue created to move tests to functional tests
//[Fact]
//public async void Emulator_MsaHeader_BotAppIdDiffers_ShouldNotValidate()
//{
// string header = $"Bearer {await new MicrosoftAppCredentials("2cd87869-38a0-4182-9251-d056e8f0ac24", "2.30Vs3VQLKt974F").GetTokenAsync()}";
// var credentials = new SimpleCredentialProvider("00000000-0000-0000-0000-000000000000", string.Empty);
// await Assert.ThrowsAsync<UnauthorizedAccessException>(
// async () => await JwtTokenValidation.ValidateAuthHeader(header, credentials, new SimpleChannelProvider(), string.Empty, null, emptyClient));
//}

/// <summary>
/// Tests with no authentication header and makes sure the service URL is not added to the trusted list.
Expand Down Expand Up @@ -135,32 +140,35 @@ public async void Channel_AuthenticationDisabledAndSkill_ShouldBeAnonymous()
Assert.Equal(AuthenticationConstants.AnonymousSkillAppId, JwtTokenValidation.GetAppIdFromClaims(claimsPrincipal.Claims));
}

[Fact]
public async void Emulator_AuthHeader_CorrectAppIdAndServiceUrl_WithGovChannelService_ShouldValidate()
{
await JwtTokenValidation_ValidateAuthHeader_WithChannelService_Succeeds(
"2cd87869-38a0-4182-9251-d056e8f0ac24", // emulator creds
"2.30Vs3VQLKt974F",
GovernmentAuthenticationConstants.ChannelService);
}

[Fact]
public async void Emulator_AuthHeader_CorrectAppIdAndServiceUrl_WithPrivateChannelService_ShouldValidate()
{
await JwtTokenValidation_ValidateAuthHeader_WithChannelService_Succeeds(
"2cd87869-38a0-4182-9251-d056e8f0ac24", // emulator creds
"2.30Vs3VQLKt974F",
"TheChannel");
}

[Fact]
public async void Connector_AuthHeader_CorrectAppIdAndServiceUrl_WithGovChannelService_ShouldValidate()
{
await JwtTokenValidation_ValidateAuthHeader_WithChannelService_Succeeds(
"2cd87869-38a0-4182-9251-d056e8f0ac24", // emulator creds
"2.30Vs3VQLKt974F",
GovernmentAuthenticationConstants.ChannelService);
}
// Disabled after appid was deleted. Issue created to move tests to functional tests
//[Fact]
//public async void Emulator_AuthHeader_CorrectAppIdAndServiceUrl_WithGovChannelService_ShouldValidate()
//{
// await JwtTokenValidation_ValidateAuthHeader_WithChannelService_Succeeds(
// "2cd87869-38a0-4182-9251-d056e8f0ac24", // emulator creds
// "2.30Vs3VQLKt974F",
// GovernmentAuthenticationConstants.ChannelService);
//}

// Disabled after appid was deleted. Issue created to move tests to functional tests
//[Fact]
//public async void Emulator_AuthHeader_CorrectAppIdAndServiceUrl_WithPrivateChannelService_ShouldValidate()
//{
// await JwtTokenValidation_ValidateAuthHeader_WithChannelService_Succeeds(
// "2cd87869-38a0-4182-9251-d056e8f0ac24", // emulator creds
// "2.30Vs3VQLKt974F",
// "TheChannel");
//}

// Disabled after appid was deleted. Issue created to move tests to functional tests
//[Fact]
//public async void Connector_AuthHeader_CorrectAppIdAndServiceUrl_WithGovChannelService_ShouldValidate()
//{
// await JwtTokenValidation_ValidateAuthHeader_WithChannelService_Succeeds(
// "2cd87869-38a0-4182-9251-d056e8f0ac24", // emulator creds
// "2.30Vs3VQLKt974F",
// GovernmentAuthenticationConstants.ChannelService);
//}

[Fact]
public async void GovernmentChannelValidation_Succeeds()
Expand Down

0 comments on commit 50ddade

Please sign in to comment.