Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Duration property to media card types #1062

Closed
JonathanFingold opened this issue Oct 25, 2018 · 4 comments
Closed

Add a Duration property to media card types #1062

JonathanFingold opened this issue Oct 25, 2018 · 4 comments
Labels
4.2 December 15, 2018 Release triaged Reviewed by the Triage Team

Comments

@JonathanFingold
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The cards spec was updated to include a media duration. I can't find a corresponding member in the Microsoft.Bot.Schema namespace, or a PR containing one.

Describe the solution you'd like

  1. Add a Duration property to media cards.
  2. Bonus: update the 06.using-cards samples.

Describe alternatives you've considered
Just pointing users to the Card schema spec.

Additional context
microsoft/botframework-sdk#5094

[enhancement]
@yochay yochay assigned yochay and unassigned yochay Oct 25, 2018
@yochay yochay added dcr triaged Reviewed by the Triage Team 4.2 December 15, 2018 Release labels Oct 25, 2018
@yochay
Copy link
Contributor

yochay commented Oct 25, 2018

Need to tag botbuilder and regenerate schema lib for C# and JS (and Java , Python).

@yochay yochay closed this as completed Oct 25, 2018
@JonathanFingold
Copy link
Contributor Author

JonathanFingold commented Oct 25, 2018 •
edited
Loading

@yochay Do you have an ETA? I was hoping to use this issue to flag when the fix was in, so I could update the docs.

@yochay yochay mentioned this issue Oct 25, 2018
Closed
@yochay
Copy link
Contributor

yochay commented Oct 25, 2018

This issue was moved to microsoft/botframework-sdk#5120

@yochay yochay mentioned this issue Oct 25, 2018
Closed
@yochay
Copy link
Contributor

yochay commented Oct 25, 2018

Moved to microsoft/botframework-sdk#5121 to track across all SDK langauges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.2 December 15, 2018 Release triaged Reviewed by the Triage Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yochay @JonathanFingold