Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button list style to the Choices for prompts #5121

Closed
yochay opened this issue Oct 25, 2018 · 14 comments
Closed

Add a button list style to the Choices for prompts #5121

yochay opened this issue Oct 25, 2018 · 14 comments
Assignees
Labels
triaged Reviewed by the Triage Team

Comments

@yochay
Copy link
Contributor

yochay commented Oct 25, 2018

From @rosskyl on October 24, 2018 18:36

Is your feature request related to a problem? Please describe.
I am upgrading a v3 bot to v4 and am working on the prompts. I am currently using a ConfirmPrompt but would like to use buttons rather than just text.

Describe the solution you'd like
It would be great to have a button list style that would display the options as a card action inside a hero card attachment.

Describe alternatives you've considered
I have looked at creating a hero card and adding card actions to it and adding that to the prompt activity. However this displays the options "(1) Yes or (2) No" as text above the card still.

Additional context
This is what I am looking for:
image
I do have some custom css styling to in the webchat.

[enhancement]

Copied from original issue: microsoft/botbuilder-dotnet#1057

@yochay yochay added DCR triaged Reviewed by the Triage Team labels Oct 25, 2018
@yochay
Copy link
Contributor Author

yochay commented Oct 25, 2018

From @sgellock on October 24, 2018 20:6

Adaptive Cards should be able to address this issue for the customer

@yochay
Copy link
Contributor Author

yochay commented Oct 25, 2018

From @nhadro on October 25, 2018 17:14

I'm working with this developer on this and the primary channel we're using is Skype for Business which doesn't support many cards from what I've seen.

@yochay
Copy link
Contributor Author

yochay commented Oct 25, 2018

Moved from microsoft/botbuilder-dotnet#1057.
DCR for all SDK languages.

@dividor
Copy link

dividor commented Oct 27, 2018

Using adaptive cards is not a great option (and not supported on all channels), the SDK 3 list style was quick and efficient to implement.

The SDK 4 choice prompt usability is questionable too, as many users are used to seeing such choice options inline in the chat rather than as - what looks like - suggested actions.

Is there any plan for SDK 4 to support list style please?

@stevengum
Copy link
Member

Inline and list formatting already exists:

const { ChoicePrompt, ListStyle } = require('botbuilder-dialogs');

const choicePrompt = new ChoicePrompt('prompt');
// Change the ListStyle of the prompt to ListStyle.none.
choicePrompt.style = ListStyle.list; // or ListStyle.inline

@rosskyl
Copy link

rosskyl commented Oct 29, 2018

That puts it inline as text. I would like buttons as they are easier for users to see and click on. I am able to get around this for the ChoicePrompt by creating a hero card with the choices as buttons and using that as the prompt and setting the ListStyle to none. But there is no way around this for others especially the ConfirmPrompt. I also think it is also a roundabout way.

@yapalex
Copy link

yapalex commented Feb 18, 2019

Has anyone found a better solution do to this? it works but its kinda of a pain.

@textminer
Copy link

I strongly believe on SDK 3 was easier and better on this than SDK 4. I'm using nodeJs with Teams channel, and I've tried:

this.dialogSet.dialogs.sourceCurrencyPrompt.style = ListStyle.heroCard; // or ListStyle.suggestedAction

and the BOT Emulator renders it whereas Teams does not.

Also tried doing:
var reply = MessageFactory.suggestedActions(['USD ($)', 'Euro (€)'], 'Choose destination currency');
await stepContext.context.sendActivity(reply);

and also, the emulator renders it perfectly and again Teams does not even show anything. Very dissapointing.

@v-kydela
Copy link

v-kydela commented May 3, 2019

@yochay - This was implemented in this pull request: microsoft/botbuilder-dotnet#1339

Should we close this issue?

@CoHealer
Copy link

CoHealer commented May 3, 2019

Closing with fix merged microsoft/botbuilder-dotnet@170e381

@CoHealer CoHealer closed this as completed May 3, 2019
@textminer
Copy link

When is this being implemented for the NodeJs SDK? Thanks.

@sgellock sgellock reopened this May 7, 2019
@sgellock
Copy link
Member

sgellock commented May 7, 2019

customer wants the v3 solution carried forward to v4.

@v-kydela
Copy link

v-kydela commented May 7, 2019

@textminer - The Node SDK has parity with .NET: microsoft/botbuilder-js#773

@sgellock
Copy link
Member

we believe this is resolved and possible with existing mechanisms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Reviewed by the Triage Team
Projects
None yet
Development

No branches or pull requests

10 participants